Discovered while porting the CKEditor Widget to Drupal core in #2994696: Render embedded media items in CKEditor.

CommentFileSizeAuthor
#3 3064273-3.patch2.45 KBoknate
#2 3064273-2.patch1.79 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new1.79 KB
oknate’s picture

StatusFileSize
new2.45 KB
  • Manual tested that css is present. 👍
  • Adding test coverage
    +    $this->assertSession()->responseContains('entity_embed.editor.css');
    +    $this->assertSession()->responseContains('hidden.module.css');
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Excellent!

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

🚢

Gave you commit credit on this one :)

  • Wim Leers committed f81291b on 8.x-1.x authored by oknate
    Issue #3064273 by Wim Leers, oknate: Use CKEditorPluginCssInterface...
oknate’s picture

sweet, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.