When validating a filter format's edit page, entity_embed_filter_format_edit_form_validate() fails to account for a scenario where 'filter_html' is disabled.
The validation function should not be concerned with HTML restrictions of a disabled filter. The result is that a site builder cannot save the filter format.
'The %embed button requires <drupal-entity> among the allowed HTML tags.'Check if 'filter_html' filter is enabled before proceeding with validation.
Submit patch
Update tests once initial review is complete
None.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | entity_embed-validation_check_filter_html_enabled-3060728-2.patch | 813 bytes | chris burge |
Comments
Comment #2
chris burge commentedComment #3
oknatecomment removed see below
Comment #4
oknateI can recreate it with the steps in the issue summary:
<drupal-entity data-entity-type data-entity-uuid data-entity-embed-display data-entity-embed-display-settings data-align data-caption data-embed-button data-langcode alt title>from allowed tagsYou get an error "The %embed button requires among the allowed HTML tags." even though html_filter has been disabled.
Comment #5
chris burge commented@oknate - Thanks for clarifying the steps to reproduce.
Comment #6
oknateWhen I use the steps in #4 with the patch applied I get this:
Thanks for raising this issue! The patch needs work though.
Comment #7
chris burge commentedClosing in favor of #3060749: entity_embed_filter_format_edit_form_validate() Logic is Faulty, which combines this issue with #3060729: entity_embed_filter_format_edit_form_validate() should check if <drupal-entity> has attributes.
@oknate - thanks for digging into this issue.
Comment #8
chris burge commented