Downloaded and installed based on instructions.

Added the Entity Embed button, see it in my ckeditor toolbar, but when i click the Entity Embed button, nothing happens. I don't see any errors in my js console.

site is using ckeditor 4.4.3

Comments

rockitdev’s picture

rockitdev commented

things i've tried:

*ckeditor 4.3.5
*Toggling various jquery versions through jquery update

i should add also i still don't see any js errors in my console.

oh no xyz’s picture

oh no xyz commented

I had the same problem after disabling all unnecessary options in the CKEditor Profile (Example URL for the Advanced CKEditor Profile: admin/config/content/ckeditor/edit/Advanced) the buttons started working for me. Not sure if I missed an option that this module requires to be disabled.
Awesome module btw ... works like the thing i imagined the last time I worked with d7

rockitdev’s picture

rockitdev commented

interesting... disabling unnecessary options is a bit vague. are you referring to the buttons loaded on the profile by default? or, some other options?

rockitdev’s picture

rockitdev commented

ok, so based on oh no xyz's recommendation, i started noodling around with various ckeditor settings.

What I have found, is that for entity embed to work, you need to disable the Advanced content filter. Once i disabled that, it began working.

oh no xyz’s picture

oh no xyz commented

sorry rockitdev, i didn't know which option was causing the issue.

But i can now confirm it's " Advanced content filter" that breaks the button/buttons, without any errors or warnings. This should be documented in the readme file and on the module page.

rockitdev’s picture

rockitdev commented

Ok, just to add to this topic. From the ckeditor project page:

Note for CKEditor 4.1+ users
If you are using CKEditor 4.1+, you may need to adjust Advanced Content Filter settings. You can do this by editing the CKEditor profiles and going to the Advanced Content Filter section, where it is possible to disable ACF completely as well as set "Extra allowed content".

devin carlson’s picture

devin carlson commented
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Category: Bug report » Support request
Status: Active » Fixed

I've documented the requirement to disable CKEditor's Advanced Content Filter on the project page and in the README.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hanno’s picture

hanno commented

I've the same issue, but advanced content filter doesn't work for me.

alison’s picture

alison
she/her
commented

I had the same issue in 7.x-2.x-dev, and I didn't want to disable ACF, but I already had things in "extra allowed content," so I added the tag that the project page says to add to the text format settings, in the CKEditor ACF syntax, so to speak -- in other words, I added this:
drupal-entity[data-*];

Could you add this to the README / project page, @Devin Carlson? It's just like the text format "allowed HTML tags" thing, but for ACF (since ACF supersedes the text format "allowed HTML tags" setting), so I think it'd just go along with the text format note in the README/project page. (I can submit a patch to update the README if that's easier.)

Regardless, hope this helps other people!

alison’s picture

alison
she/her
commented

And/Or, maybe we should backport this functionality?
#2554687: <drupal-entity> tag not being automatically added when an Entity Embed button is added to active editor toolbar

alison’s picture

alison
she/her
commented
Related issues: +#2554687: <drupal-entity> tag not being automatically added when an Entity Embed button is added to active editor toolbar