Problem/Motivation

When other modules try to provide information about local tasks, a developer takes a look at or steps through code, local tasks should sport their provider when using getPluginDefinition.

Proposed resolution

Add 'provider' information / index to array in DynamicLocalTasks.php

Issue fork entity_clone-3301132

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

attisan created an issue. See original summary.

attisan opened merge request !14

attisan’s picture

attisan
Location Vienna
commented
Status: Active » Needs review
jonmcl’s picture

jonmcl commented
Status: Needs review » Reviewed & tested by the community

Yes please. Without this fix, this module causes a fatal error with the entity_ui module because that module attempts to get this module's label in the EntityTabListBuilder class.

Completely correct to add provider to tabs created by a derivative plugin.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Needs work

This isn't the right fix.

Plugin derivers should add to the $base_plugin_definition that getDerivativeDefinitions() receives, and that will already contain a 'deriver' key -- as well as other useful stuff that you should be using.