Problem/Motivation

https://www.drupal.org/node/3422670

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_browser-3615285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

velmir_taky created an issue. See original summary.

velmir_taky opened merge request !153

velmir_taky’s picture

velmir_taky commented
Assigned: velmir_taky » Unassigned
Status: Active » Needs review
velmir_taky’s picture

velmir_taky commented

Went as far native as modal.js allows. What's left on jQuery is the entities-selected event (bound by core AJAX #ajax event and triggered by integrations) and the jQuery UI dialog in fluidDialog — changing those would break BC. Verified modal open/close/Escape/throbber in a real browser.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

this went a bit further than I expected, but that's ok, I have two questions though.

velmir_taky’s picture

velmir_taky commented
Status: Needs work » Needs review

Both addressed and pushed, tested in the browser too.

  • berdir committed d4b82520 on 8.x-2.x authored by velmir_taky 
    task: #3615285 Switch dialog events to the native event format (CR...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks for sticking with this, merged now. next major is currently broken, but we can fix that in the parent issue.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.