As CKEditor 4 has been deprecated and removed in Drupal 10 and subsequent versions, we should initiate the removal of CKEditor 4 from our module. Following its removal, it would be prudent to release a new major or minor version that exclusively supports CKEditor 5.

And since we are dropping ckeditor4 support we need to refactor ckeditor5 code for embed module

Issue fork embed-3450289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

deepakkm created an issue. See original summary.

deepakkm opened merge request !17

deepakkm’s picture

deepakkm commented
Title: Drop support of CKEditor4 » Drop support of CKEditor4 and include functionjavascript tests for ckeditor5
Issue summary: View changes
znerol’s picture

znerol commented
Parent issue: #3430097: Automated Drupal 11 compatibility fixes for embed »
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Version: 8.x-1.x-dev » 2.0.x-dev

We should adjust this MR to re-target the 2.0.x branch. I think 8.x-1.x is pretty much at the end of the line.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I think we can just bump the minimum version of Drupal 10 supported to 10.5 when CKEditor was updated. I don't see a need for a new branch quite yet.