See also https://www.drupal.org/node/2640086 and https://www.drupal.org/node/2678324.

CommentFileSizeAuthor
#2 embed-2778355-drupal-theme-bootstrapModal-is-not-a-function.patch395 bytesvolkerk

Comments

volkerk created an issue. See original summary.

volkerk’s picture

volkerk commented
StatusFileSize
new embed-2778355-drupal-theme-bootstrapModal-is-not-a-function.patch395 bytes
volkerk’s picture

volkerk commented
Status: Active » Needs review
slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +D8Media

Looks good to me.

a.dmitriiev’s picture

a.dmitriiev commented

I also tested and now finally CKEditor "loves" embed entities with entity browser.

Thanks for the patch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #2 to 8.x-1.x. Thanks all!

  • Dave Reid committed aee94ea on 8.x-1.x authored by volkerk 
    Issue #2778355 by volkerk: Fixed TypeError: Drupal.theme.bootstrapModal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Media Initiative
Related issues: +#2640086: Editor routes don't use the ajax_base_page theme negotiator, +#2678324: TypeError: Drupal.theme.bootstrapModal is not a function
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2844822: The preview in CKEditor does not use the same Twig template as the one on the front end (default theme)

#2844822: The preview in CKEditor does not use the same Twig template as the one on the front end (default theme) reported the same bug, but this fortunately already fixed it! 👌