Steps:

1) Navigate to Add new Comment Box
2) Select Restricted HTML as Text format
3) Observe
Actual: Comments: The UI distorts on selection Restricted HTML

text-format

Comments

Neetika K created an issue. See original summary.

bandanasharma’s picture

Issue summary: View changes
brahmjeet789’s picture

Assigned: Unassigned » brahmjeet789
rahulrasgon’s picture

Status: Active » Needs review
StatusFileSize
new321 bytes
new46.05 KB

Here is the patch and screenshot too. Need Reviews.

brahmjeet789’s picture

Status: Needs review » Needs work
StatusFileSize
new140.31 KB

@rahulrasgon your last patch causes error ,please refer to screenshot.

rahulrasgon’s picture

Sorry Guys, got some testing code in local machine, that's why that patch was not applying. Here is the updated patch. Working fine for me. Needs Review.

rahulrasgon’s picture

Status: Needs work » Needs review
brahmjeet789’s picture

Status: Needs review » Needs work
Checking patch src/sass/layout/_node.scss...
error: while searching for:
.content-wrapper {
  padding: rem(60px 0);
}

error: patch failed: src/sass/layout/_node.scss:1
error: src/sass/layout/_node.scss: patch does not apply

I am facing these type of errors while applying your patch.

rahulrasgon’s picture

StatusFileSize
new60.01 KB

Hello Brahmjeet789,
I just cross check the patch and working fine for me. Kindly make sure you are applying the patch in right way as mentioned here Git Instructions.

I have attached the screenshot of steps followed by me. And let me know if others are facing the same issues.

bandanasharma’s picture

StatusFileSize
new40.39 KB

#6 patch is apply successfully. It's working fine on Chrome and Firefox. attached the screen shot.
But some coding standard issues find in the scss file such as:
1. No new line in the end of the file
2. No one space after colon in the property.

bandanasharma’s picture

Status: Needs work » Needs review
StatusFileSize
new317 bytes

Make these changes and upload the patch.

bandanasharma’s picture

Assigned: brahmjeet789 » Unassigned
brahmjeet789’s picture

@bandana: your patch is applied successfully and i can see the changes in the comment so i am moving this issue to RTBC.

brahmjeet789’s picture

Status: Needs review » Reviewed & tested by the community
sreenivas bttv’s picture

Assigned: Unassigned » sreenivas bttv
sreenivas bttv’s picture

Status: Reviewed & tested by the community » Needs work

@bandanasharma patch electra-updated_comment_fix_ui_on_restricted_html-2975212-11.patch is not the right solution. It works only for comment form. So need to fix towards textarea element if available in any form.

  • Sreenivas Bttv committed 9b619c8 on 8.x-1.x
    Issue #2975212 by Sreenivas Bttv: Comments: The UI distorts on selection...
sreenivas bttv’s picture

Committed and pushed to 8.x-1.x branch

sreenivas bttv’s picture

Status: Needs work » Fixed
sreenivas bttv’s picture

Assigned: sreenivas bttv » Unassigned
sreenivas bttv’s picture

Status: Fixed » Closed (fixed)