Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
CKEditor 5 readiness issue to tackle all the thing to make this module work with CK-editor 5.
Steps to reproduce
Enable CK-editor5 and select it as editor. Use this module in the same text text format & enable one of the filters.
It gives the status message:
CKEditor 5 only works with HTML-based text formats. The... ... filter implies this text format is not HTML anymore.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #28 | 3307959_mr2_175c901c_28.patch | 17.25 KB | ericdsd |
Issue fork editor_button_link-3307959
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
martijn de witSeems this happens because of the type definition.
type = Drupal\filter\Plugin\FilterInterface::TYPE_MARKUP_LANGUAGEChanging this to
type = Drupal\filter\Plugin\FilterInterface::TYPE_TRANSFORM_REVERSIBLECould resolve the problem. Only I don't know what happens with existing content in text fields if we change this.
Comment #3
danthorneAdded project to this list https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckedito...
Comment #4
martijn de wit@danthorne thnx for the ping.
Comment #5
martijn de witwatching the solutions of other modules they all use
FilterInterface::TYPE_TRANSFORM_IRREVERSIBLEGuess we should use that too.
---Source:
https://git.drupalcode.org/project/insert_view/-/commit/f22f505
https://git.drupalcode.org/project/autofloat/-/commit/90e2c0d
https://git.drupalcode.org/project/toc_filter/-/commit/96a3762
Comment #6
danthorneSwitching to
FilterInterface::TYPE_TRANSFORM_REVERSIBLEgets rid of the below error when choosing text editorComment #7
coen van vliet commentedAdding a patch with the suggested change.
Comment #8
martijn de witThink we also have to modify the way, the extra fields are going to display in the new CK5 link pop-up
Comment #9
chrissnyderFor CKEditor 5, the ckeditor_link_styles module provides similar functionality.
Comment #10
danthorneThanks @ChrisSnyder
Just had a play with your module but currently there's no way to choose only one style. Example there could be 2 button styles and the editor could tick both by mistake.
Also this module adds attributes in the editor like
data-drupal-button-link="button" data-drupal-button-link-style="button--primary"instead of just adding the class, which avoids admin theme conflict. Example, the gin admin theme also has a class of button, which looks different to the button that will be rendered in the frontend.Comment #11
bakulahluwalia#7 patch works just fine. No issues in the existing buttons as well. Any plans to merge it to upcoming release?
Comment #12
carolea commentedHi,
Any updates on this please?
We would need a fix as well.
We've applied the patch but I don't see the type and styles dropdowns anymore.
Thanks!
Comment #13
martijn de witWill check this in coming weeks.
Comment #14
ericdsd commentedHi is there any progress on this, i'd be happy to help testing as a non dev.
Comment #15
martijn de witComment #16
martijn de witSeems we have to rewrite a part of the module and create an upgrade path.
going to use the fork for this.
Comment #17
martijn de witCommitted some code to start. Still needs some work.
Comment #18
martijn de witComment #20
martijn de witComment #21
ericdsd commentedGreat to see this issue is moving, i'll be glad to help testing once needed.
Comment #24
danthorneCKEditor 4 is no longer supported as of today.
Comment #26
martijn de witWe are developing the new version at the 3.x branch.
PHP part is roughly done. JS part has to be done.
Comment #27
dima.iluschenkoHi @Martijn de Wit!
Do you know the approximate date when this will be ready?
Comment #28
ericdsd commentedAttaching patch version of MR2 (#23) as it's now required instead of #7 patch that's not compatible with core 10.3+ (prevents saving text format).