I really think this should be in core for Drupal 7 and wanted to chat to anyone else who would be interested in getting this into core before we post it to the list of Drupal 7 patches.

Comments

mcurry’s picture

mcurry commented

+1 from the author.

I use this module on every site I touch.

The current implementation of ed_readmore has some problems dealing with finding a proper insertion point for the inline read more <span> - so it this ends up in core, it'll need some work.

SeanBannister’s picture

SeanBannister commented

Well if it ends up in core we can play directly with the core code so we won't be stuck with module limitations.
I can't say I've looked at the code yet but I'm sure it'll be a completely different approach when modifying core.

fletchgqc’s picture

fletchgqc commented

The option to have Read more inline should be in core in some way shape or form.

SeanBannister’s picture

SeanBannister commented

Ok, there's an issue at http://drupal.org/node/16161 talking about getting it into core.

thomas23@drupal.org’s picture

thomas23@drupal.org commented

subscribe

mcurry’s picture

mcurry commented

I've added a blurb mentioning this and #16161: Move Read More link to end of node content in the project description; maybe this will help get some traction in the effort to move this functionality into core. Thanks to Sean Bannister for the suggestion.

keesje’s picture

keesje commented

+1 for this to be a simple theme-dependant switch "Inline readmore links TRUE/FALSE" in the theme administration area.

tobiass’s picture

tobiass commented

supporting #7

onejam’s picture

onejam commented

I think this is great and perhaps should be part of the core for D7 and filed under post-settings page. However, i also think only when you can define a different 'read more' text for other content-type teasers, it will be more useful.

Perhaps it should be in Views 2 as a field option?

keesje’s picture

keesje commented

I think a basic implementation in core with an overrride option for e.g. Views2 to have more advanced options would be perfect :).

momper’s picture

momper commented

+1

todd nienkerk’s picture

todd nienkerk commented
Version: 6.x-2.0-beta1 » 6.x-3.x-dev

+1

Please review major changes to 6.x-3.x-dev. They could be useful for 7.x.

funana’s picture

funana commented

definitely! +++1 for that!

drifter’s picture

drifter commented

+1 yes!

todd nienkerk’s picture

todd nienkerk commented
Status: Active » Closed (won't fix)

I'm glad that everyone is excited to include this in core, but it's totally out of scope for this module. We can't address core issues here. But... You can talk about it here: #16161: Move Read More link to end of node content.

danfinney’s picture

danfinney commented

+2 (my wife thinks so too)

todd nienkerk’s picture

todd nienkerk commented

danfinney: Thanks for +2, but please note that this issue won't get anything contributed to Drupal core. Please voice your support here: #16161: Move Read More link to end of node content.

Cactii1’s picture

Cactii1 commented

+1

babbage’s picture

babbage commented

Before you post a +1 to the issue that Todd Nienkerk linked to, please see: http://drupal.org/node/16161#comment-1838922

At this point, it would be highly counterproductive to "voice your support" there—unless you are doing so by attaching a patch that fixes the issue. Just a friendly suggestion. :)

Gabriel R.’s picture

Gabriel R. commented

A big +1 from me too. I use the module on every site, on various languages.

todd nienkerk’s picture

todd nienkerk commented

Please don't +1 this issue. There's nothing that can be done about Drupal core here. Furthermore, Drupal 7 is in code freeze. If you want this feature added to Drupal core, please submit a patch to Drupal 8 after Drupal 7 is release.

SeanBannister’s picture

SeanBannister commented

Might still be able to get it in as a usability improvment even though we're in code freeze, especially if it's before October 15th because we're in a code slush

femrich’s picture

femrich commented

Yes, absolutely should be in core. No excuses for the placement of the read more link we have to live with now, and the drupal 7 read more project looks like it isn't going anywhere very quickly. (http://drupal.org/project/read_more) Wish I knew even a little bit about coding...