Closed (fixed)
Project:
e-Commerce
Component:
shipping.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2005 at 15:15 UTC
Updated:
6 Oct 2005 at 07:20 UTC
Jump to comment: Most recent file
While finalizing the hungarian translation, I found, that some strings are missing from the po files. Another problem was, when clicking on the "Send shipping notification" button (using Hungarian language), the shipping options page raised, and no notification was sent.
I found the following strings without the t() function:
22c22
< case 'Shipping email':
---
> case t('Shipping email'):
46,47c46,47
< $output = form_textfield(t('Subject of shipping e-mail'), "shipping_subject", variable_get("shipping_subject", "Your %site order has shipped (#%txnid)"), 70, 180);
< $output .= form_textarea(t("Shipping email"), "shipping_new", variable_get("shipping_new", shipping_help("Shipping email")), 70, 10, "This text will be emailed to customers after their order has been shipped.");
---
> $output = form_textfield(t('Subject of shipping e-mail'), "shipping_subject", variable_get("shipping_subject", t("Your %site order has shipped (#%txnid)")), 70, 180);
> $output .= form_textarea(t("Shipping email"), "shipping_new", variable_get("shipping_new", shipping_help("Shipping email")), 70, 10, t("This text will be emailed to customers after their order has been shipped."));
121c121
< $group .= form_submit("Save configuration");
---
> $group .= form_submit(t("Save configuration"));
144c144
< $shipping_to = "Shipping to:\n";
---
> $shipping_to = t("Shipping to:\n");
151c151
< $billing_to = "Billing to:\n";
---
> $billing_to = t("Billing to:\n");
190,191c190,191
< $subject = strtr(variable_get("shipping_subject", "Your %site order has shipped (#%txnid)"), $variables);
< $body = strtr(variable_get("shipping_new", shipping_help("Shipping email")), $variables);
---
> $subject = strtr(variable_get("shipping_subject", t("Your %site order has shipped (#%txnid)")), $variables);
> $body = strtr(variable_get("shipping_new", shipping_help(t("Shipping email"))), $variables);
211c211
< $form .= form_submit('Send shipping notification');
---
> $form .= form_submit(t('Send shipping notification'));
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | shipping.module_0.patch | 3.97 KB | pentike |
Comments
Comment #1
matt westgate commentedCan you please create a unified diff and add it as an attachment to this issue? See link below for details.
http://drupal.org/patch
Thanks!
Comment #2
pentike commentedSorry!
I could thought, the unified format is more usefull, but it seemed to be too long to include.
Comment #3
pentike commentedOops. I fortuitously changed the report's title. Now it shall be good.
Comment #4
matt westgate commentedPatch applied to 4.6 and HEAD. Thanks!
Comment #5
(not verified) commentedComment #6
(not verified) commentedComment #7
(not verified) commentedComment #8
(not verified) commentedComment #9
(not verified) commented