While finalizing the hungarian translation, I found, that some strings are missing from the po files. Another problem was, when clicking on the "Send shipping notification" button (using Hungarian language), the shipping options page raised, and no notification was sent.

I found the following strings without the t() function:

22c22
<     case 'Shipping email':
---
>     case t('Shipping email'):
46,47c46,47
<   $output = form_textfield(t('Subject of shipping e-mail'), "shipping_subject", variable_get("shipping_subject", "Your %site order has shipped (#%txnid)"), 70, 180);
<   $output .= form_textarea(t("Shipping email"), "shipping_new", variable_get("shipping_new", shipping_help("Shipping email")), 70, 10, "This text will be emailed to customers after their order has been shipped.");
---
>   $output = form_textfield(t('Subject of shipping e-mail'), "shipping_subject", variable_get("shipping_subject", t("Your %site order has shipped (#%txnid)")), 70, 180);
>   $output .= form_textarea(t("Shipping email"), "shipping_new", variable_get("shipping_new", shipping_help("Shipping email")), 70, 10, t("This text will be emailed to customers after their order has been shipped."));
121c121
<   $group .= form_submit("Save configuration");
---
>   $group .= form_submit(t("Save configuration"));
144c144
<     $shipping_to = "Shipping to:\n";
---
>     $shipping_to = t("Shipping to:\n");
151c151
<   $billing_to = "Billing to:\n";
---
>   $billing_to = t("Billing to:\n");
190,191c190,191
<   $subject    = strtr(variable_get("shipping_subject", "Your %site order has shipped (#%txnid)"), $variables);
<   $body       = strtr(variable_get("shipping_new", shipping_help("Shipping email")), $variables);
---
>   $subject    = strtr(variable_get("shipping_subject", t("Your %site order has shipped (#%txnid)")), $variables);
>   $body       = strtr(variable_get("shipping_new", shipping_help(t("Shipping email"))), $variables);
211c211
<   $form .= form_submit('Send shipping notification');
---
>   $form .= form_submit(t('Send shipping notification'));
CommentFileSizeAuthor
#2 shipping.module_0.patch3.97 KBpentike

Comments

matt westgate’s picture

Can you please create a unified diff and add it as an attachment to this issue? See link below for details.

http://drupal.org/patch

Thanks!

pentike’s picture

Title: Missing t() functions in shipping.module 4.6.0 » diff -u
StatusFileSize
new3.97 KB

Sorry!

I could thought, the unified format is more usefull, but it seemed to be too long to include.

pentike’s picture

Title: diff -u » Missing t() functions in shipping.module 4.6.0

Oops. I fortuitously changed the report's title. Now it shall be good.

matt westgate’s picture

Status: Needs review » Fixed

Patch applied to 4.6 and HEAD. Thanks!

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)