The code that was added in https://www.drupal.org/node/3419237 breaks the Follow Redirects configuration on subdirectory installations, ie. http://example.com/site , as is evidenced in https://www.drupal.org/project/easy_breadcrumb/issues/3615339.

The steps to reproduce in https://www.drupal.org/node/3419237 do not reproduce the bug described and that issue did not have any associated tests.

It seems the right thing to do, based on https://www.drupal.org/project/easy_breadcrumb/issues/3615339#comment-16..., "Since $path is already base-path free, the base-path block looks unnecessary for the redirect lookup — dropping it (or stripping the base path instead of adding it) should make the feature work in both setups", is to revert the commit from https://www.drupal.org/node/3419237 and to add the test from https://www.drupal.org/project/easy_breadcrumb/issues/3615339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

loopduplicate created an issue. See original summary.

loopduplicate’s picture

Assigned: loopduplicate » Unassigned

OK, I give up for today. I just can't beat this. Another failure on gitlab CI that isn't failing locally.

loopduplicate’s picture

Status: Active » Needs review

This was a very difficult issue to debug. There were issues with base path and language handling that made the code work on most sites but not always with multilingual sites or with sites that are not served directly from the root of the domain but from a subdirectory, ie. http://example.com/subdirectory/index.php

I have left comments in the merge request and in the code.

loopduplicate’s picture

Assigned: Unassigned » loopduplicate
Status: Needs review » Needs work

Needs to be rebased.

loopduplicate changed the visibility of the branch 3615550-follow-redirects-config-4 to hidden.

loopduplicate’s picture

Assigned: loopduplicate » Unassigned
Status: Needs work » Needs review