i have a couple menu items that use the tag. this tag is being printed in the breadcrumb. the allow html option provided by menu_html does not have any effect on the breadcrumb. how can allow html for the breadcrumb so these tags do not display in the breadcrumb? i checked configuration page and there is no option for that. many thanks

Steps to reproduce:

Add Administration::Admin In the setting for "Breadcrumbs to be replaced while generating segments " and visit any admin page.

CommentFileSizeAuthor
#10 easy_breadcrumb-fix_allow_html-2912889-10.patch1.2 KBtatarbj
#7 easy_breadcrumb-fix_allow_html-2912889-7.patch1.39 KBjenlampton

Comments

drupalstrap created an issue. See original summary.

pyxio’s picture

pyxio commented
Title: allow html tags in breadcrumb » not working with menu_html module
Issue summary: View changes
pyxio’s picture

pyxio commented
Status: Active » Needs work

so i solved this by unchecking 'Allow HTML tags in crumbs.' option in easy breadcrumb configuration. the description is 'Uncheck it if you don't want to allow HTML tags in your crumbs.' which seems like the exact opposite of what i wanted since i have html span tags in my menu link titles. anyway, it is working now.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Component: Miscellaneous » User interface
Assigned: Unassigned » tatarbj

Hey drupalstrap!

Thanks for letting us know about this issue, it seems for me the solution would be to make that text a bit more understandable - do you have a proposal for it that we could include in a new release, crediting you for that? :)

@Greg I'm also lost and have to think when i see that label, maybe with some other texts we could clean it up a bit, what do you think?

Bests,
Balazs.

jenlampton’s picture

jenlampton
she / her
commented
Title: not working with menu_html module » Clean up the whole user-interface, checkbox labels can be misleading
Assigned: tatarbj » jenlampton
Category: Support request » Task
Status: Needs work » Active

I'd like to take a stab at cleaning up the user interface. User experience is very important to the Backdrop community, and I'd love for improvements we make to the Backdrop version of the module to be included for Drupal as well. Please see: https://www.drupal.org/project/easy_breadcrumb/issues/2938421

jenlampton’s picture

jenlampton
she / her
commented
Title: Clean up the whole user-interface, checkbox labels can be misleading » not working with menu_html module
Component: User interface » Miscellaneous

oops, decided to make a new issue for that. Changing title back :)

jenlampton’s picture

jenlampton
she / her
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new easy_breadcrumb-fix_allow_html-2912889-7.patch1.39 KB

The problem is that this setting controls whether tags are stripped from the breadcrumb text, or not. If they aren't stripped, the breadcrumb is rendered as though it contained plain text, and not HTML. All we need to do is add HTML = TRUE to the l() function and we should be golden.

Status: Needs review » Needs work

The last submitted patch, 7: easy_breadcrumb-fix_allow_html-2912889-7.patch, failed testing. View results

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Parent issue: » #2938503: New minor release of 7.x
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
StatusFileSize
new easy_breadcrumb-fix_allow_html-2912889-10.patch1.2 KB

I've just noticed why the patch failed: the changes are made on the backdrop version of the module, not the d.org one :(
After reroll and tests I'm committing it to dev now.

  • tatarbj committed 3e114ac on 7.x-2.x 
    Issue #2912889 by tatarbj, jenlampton, drupalstrap: not working with...
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Assigned: jenlampton » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.