The HEAD is failing on D9 since #2986452: Database reserved keywords need to be quoted as per the ANSI standard.

CommentFileSizeAuthor
#18 3129590-17.patch4.6 KBjibran
#18 interdiff-6e6068.txt2.72 KBjibran
#17 3129590-16.patch7.01 KBjibran
#17 interdiff-d0286b.txt1.22 KBjibran
#15 3129590-15.patch7.14 KBjibran
#15 interdiff-515bd0.txt646 bytesjibran
#14 3129590-14.patch7.15 KBjibran
#14 interdiff-83cef1.txt653 bytesjibran
#13 3129590-13.patch7.01 KBjibran
#13 interdiff-52bae4.txt935 bytesjibran
#12 3129590-12.patch7.01 KBjibran
#12 interdiff-17ba64.txt1.83 KBjibran
#11 3129590-11.patch6.05 KBjibran
#11 interdiff-e97ae6.txt657 bytesjibran
#10 3129590-10.patch6.04 KBjibran
#10 interdiff-612b86.txt2.3 KBjibran
#8 3129590-8.patch4.27 KBjibran
#8 interdiff-c2c1db.txt2.37 KBjibran
#7 3129590-7.patch2.8 KBjibran
#7 interdiff-5084be.txt2.6 KBjibran
#4 3129590-3.patch4.76 KBjibran
#3 8.x-2.x-3129590-2.patch3.6 KBjibran
#3 interdiff-b37179.txt3.18 KBjibran
#2 8.x-2.x-3129590-2.patch3.6 KBjibran
#2 8.x-1.x-3129590-2.patch2.17 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 8.x-1.x-3129590-2.patch2.17 KB
new 8.x-2.x-3129590-2.patch3.6 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-b37179.txt3.18 KB
new 8.x-2.x-3129590-2.patch3.6 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 3129590-3.patch4.76 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

7.4 and 7.3 fails show that triggers are not set up properly.

daffie’s picture

daffie commented

I have looked at the patch and I see that you are adding the method escapeField() is a couple of places. What the method returns has changed a little bit in that it return the field name with quotes added to the name (for Drupal 9). Maybe something goes wrong when you create the triggers when the field names are quoted?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-5084be.txt2.6 KB
new 3129590-7.patch2.8 KB

We don't need to add the quotes here so I reverted it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-c2c1db.txt2.37 KB
new 3129590-8.patch4.27 KB

I found the reason for fails. \Drupal\Core\Database\Connection::quoteIdentifiers() is stripping out the sqaure breckets from the tiggers REGEX.

Status: Needs review » Needs work

The last submitted patch, 8: 3129590-8.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-612b86.txt2.3 KB
new 3129590-10.patch6.04 KB

Let's fix some fail for pgsql and sqlite.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-e97ae6.txt657 bytes
new 3129590-11.patch6.05 KB

Let's try this.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-17ba64.txt1.83 KB
new 3129590-12.patch7.01 KB

Created the helper method.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-52bae4.txt935 bytes
new 3129590-13.patch7.01 KB

c/p error.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-83cef1.txt653 bytes
new 3129590-14.patch7.15 KB

Hopefully, this would be it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-515bd0.txt646 bytes
new 3129590-15.patch7.14 KB

hmmm

daffie’s picture

daffie commented

@jibran: Maybe you did not know that: the difference between SQLite and the other 2 databases is that prefixing works a little bit different. SQLite separates the prefix and the table name with a dot.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-d0286b.txt1.22 KB
new 3129590-16.patch7.01 KB

Let's try this.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-6e6068.txt2.72 KB
new 3129590-17.patch4.6 KB

Hehe, @daffie yeah, I'm trying to figure it out as I go :D

Status: Needs review » Needs work

The last submitted patch, 18: 3129590-17.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Yay!!! green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 3129590-17.patch, failed testing. View results

  • jibran committed cd9f306 on 8.x-1.x 
    Issue #3129590 by jibran: Make DER green for D9 branch

  • jibran committed 6f97646 on 8.x-2.x 
    Issue #3129590 by jibran, daffie, chx: Make DER green for D9 branch

jibran credited chx.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Fixed

Thank you @daffie and @chx for the help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.