target_id_int column doesn't exist for field revision table

Here is the basic test for start. It passes on both 8.x-1.x and 8.x-2.x.

• Added a failing test
• Fixed the bug by adding the triggers on revision tables.
• Update path fix can go to follow up with tests.

Fixed the stupid copy paste error.

Minor observation.

1. +++ b/src/EventSubscriber/FieldStorageSubscriber.php
   @@ -137,6 +139,9 @@ class FieldStorageSubscriber implements EventSubscriberInterface {
   +        if ($entity_type->isRevisionable() && ($table = $mapping->getDedicatedRevisionTableName($field_storage_definition))) {
   

   Field Revision table is always a dedicated table if an entity is revisionable.

2. +++ b/src/EventSubscriber/FieldStorageSubscriber.php
   @@ -137,6 +139,9 @@ class FieldStorageSubscriber implements EventSubscriberInterface {
   +          $tables[$table][] = $column;
   

   column name is same across the tables.

Added #2773099: Add tests for base fields of revisonable entity as a follow up. After that we can work on upgrade path test for base fields of revisonable entity.

$field_storage_definition can be NULL so changed the variable.

These fails are in the HEAD because of #2775539: DerUpdateTest is failing after 2755525 and #2755525: Invoke field methods first on the current entity translation.

Current patch is only fixing the bug: "target_id_int column doesn't exist for entity revision field tables."

field revision table only exist if both entity and field storage are revisionable.

Thanks for the explanation. Here is the new patch

Thanks! committed and pushed to 8.x-2.x

+++ b/dynamic_entity_reference.install
@@ -64,12 +65,28 @@ function dynamic_entity_reference_update_8001() {
+        $revision_table = NULL;
+        if ($entity_type->isRevisionable() && $field_storage_definition->isRevisionable()) {
+          if ($table_mapping->requiresDedicatedTableStorage($field_storage_definition)) {
+            $revision_table = $table_mapping->getDedicatedRevisionTableName($field_storage_definition);
+          }
+          elseif ($table_mapping->allowsSharedTableStorage($field_storage_definition)) {
+            $revision_table = $entity_type->getRevisionDataTable() ?: $entity_type->getRevisionTable();
+          }
+          $schema->changeField($revision_table, $column, $column, $spec);
+          $schema->changeField($revision_table, $type_column, $type_column, $type_spec);
+        }
...
+          if ($revision_table) {
+            $field_schema_data[$revision_table]['fields'][$column] = $spec;
+            $field_schema_data[$revision_table]['fields'][$type_column] = $type_spec;
+            $entity_storage_schema_sql->set($key, $field_schema_data);
+          }

Just for the record the upgrade path test for this change is still pending.