Immediately after installing this module, I got the following message:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in [path removed]drupal/sites/all/modules/drutex/drutex_remote.inc on line 288

This is line 288

if (ip_valid(&$_SERVER[$c])) {

Based on the advice for this similar issue, I removed the ampersand:

if (ip_valid($_SERVER[$c])) {

and the error no longer appears. Is this a good solution or does it break something that I haven't noticed yet?

Comments

vyvee’s picture

vyvee commented

I suffer from the same problem too. I've examined the function ip_valid()... and as far as I can tell, it doesn't modify the parameter. So it should be safe to workaround so. Didn't notice that it breaks anything too.

steven jones’s picture

steven jones commented
Version: 5.x-1.2 » master
Status: Needs review » Fixed

Fixed in HEAD, thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.