I've fixed 2 bugs and attached them with this patch:

  • After completing an action, the module would forward to admin/drupalvb which is invalid. This has been changed to admin/settings/drupalvb
  • When exporting from Drupal to vB, duplicates would not be detected. This was because the parenthesis was in the wrong place, so it would look for user "%s" instead of the username. This has been fixed.

I also added an import-from-vBulletin feature so established forums can migrate their userbases into new Drupal sites. Enjoy!

Comments

rszrama’s picture

Awesome! I'll check these out and commit ASAP. Hopefully this evening.

kkronyak’s picture

I will be testing these features on a real albeit small site very soon so I'll let you know if there are any problems. However in my development / test site, everything worked fine.

kkronyak’s picture

I found last night that the passwords do NOT import propertly from vBulletin. I do not have a lot of experience with vB so i'm not sure exactly how it hashes the passwords, but I may look into it further tonight or over the weekend.

The other crucial parts of the account (e-mail and username) do import properly though, so the import feature is still valuable for at least pre-loading the accounts. What we did with the site i'm working on is make a notice telling users to run the Retrieve Password process in order to get into their Drupal accounts.

I don't know if importing will ever work, depending on how vB stores the passwords. It may just be the nature of the beast.

sun’s picture

Version: 5.x-1.0 » 6.x-2.x-dev
Category: bug » feature
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.72 KB

Re-rolled patch against HEAD. Watch your coding-style.

sun’s picture

Title: Bad forward after actions, bad duplicate prevention, new import feature. » Allow to import vB users into Drupal
StatusFileSize
new1.72 KB

Re-rolled patch against HEAD.

sun’s picture

Version: 6.x-2.x-dev » 5.x-2.x-dev
Assigned: kkronyak » sun
Status: Needs review » Needs work
StatusFileSize
new2.77 KB

I've re-written this patch for 5.x-2.x now. However, I doubt it will be of any use, because vBulletin stores user passwords with an additional salt (like D7). So if a user is imported through this function, she will never be able to login, because MD5($user->pass) != MD5($user->pass . $user->salt).

As mentioned in the patch, we need to replace this function with a lazy user instantiation via hook_auth(). After that, we might fill the authmap table with imported data, but definitely not like in this current approach.

sun’s picture

Version: 5.x-2.x-dev » 5.x-2.0-beta1
Status: Needs work » Fixed

Lazy instantiation of existing vB users in Drupal is now implemented in 5.x-2.0-RC1.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.