Closed (fixed)
Project:
Drupal vB
Version:
5.x-2.0-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
21 Feb 2007 at 03:55 UTC
Updated:
14 May 2008 at 00:12 UTC
Jump to comment: Most recent file
I've fixed 2 bugs and attached them with this patch:
I also added an import-from-vBulletin feature so established forums can migrate their userbases into new Drupal sites. Enjoy!
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | drupalvb-DRUPAL-5--2.user-import.patch | 2.77 KB | sun |
| #5 | drupalvb.user-import.patch | 1.72 KB | sun |
| #4 | drupalvb.user-import.patch | 1.72 KB | sun |
| drupalvbfix.patch | 3.43 KB | kkronyak |
Comments
Comment #1
rszrama commentedAwesome! I'll check these out and commit ASAP. Hopefully this evening.
Comment #2
kkronyak commentedI will be testing these features on a real albeit small site very soon so I'll let you know if there are any problems. However in my development / test site, everything worked fine.
Comment #3
kkronyak commentedI found last night that the passwords do NOT import propertly from vBulletin. I do not have a lot of experience with vB so i'm not sure exactly how it hashes the passwords, but I may look into it further tonight or over the weekend.
The other crucial parts of the account (e-mail and username) do import properly though, so the import feature is still valuable for at least pre-loading the accounts. What we did with the site i'm working on is make a notice telling users to run the Retrieve Password process in order to get into their Drupal accounts.
I don't know if importing will ever work, depending on how vB stores the passwords. It may just be the nature of the beast.
Comment #4
sunRe-rolled patch against HEAD. Watch your coding-style.
Comment #5
sunRe-rolled patch against HEAD.
Comment #6
sunI've re-written this patch for 5.x-2.x now. However, I doubt it will be of any use, because vBulletin stores user passwords with an additional salt (like D7). So if a user is imported through this function, she will never be able to login, because
MD5($user->pass)!=MD5($user->pass . $user->salt).As mentioned in the patch, we need to replace this function with a lazy user instantiation via hook_auth(). After that, we might fill the authmap table with imported data, but definitely not like in this current approach.
Comment #7
sunLazy instantiation of existing vB users in Drupal is now implemented in 5.x-2.0-RC1.
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.