The JS is partly of working, but the validation doesn't actually work anymore -- you can preview release nodes without the "Are you sure" checkbox selected without validation errors, you can submit, etc. When you preview, the "Are you sure" checkbox is completely lost, in fact.

Comments

hunmonk’s picture

Status: Active » Needs review
StatusFileSize
new2.63 KB

yikes, lots of breakage here...

  • because of the function name, and because it's called manually, drupalorg_form_project_release_node_form_alter() was being called twice. not sure exactly what that was breaking, but it can't be good ;) i tried just removing the general form_alter manual call, but that seemed to break the js, so instead i renamed the function so that the specific form_alter wasn't called.
  • the #validate attribute was declared using the 5.x format.
  • drupalorg_security_release_form_validate() made references to $form_values instead of $form_state['values']

attached patch fixes the validation on preview from my testing. i believe that the loss of the Release type terms defaults on preview is more of 6.x preview hell, and probably needs a hack in project_release module to fix properly.

hunmonk’s picture

the loss of values on preview is now being handled over at #382634: Previewing multiselect taxonomy fields lose value on multistep node forms

dww’s picture

Status: Needs review » Fixed

Reviewed, tested, ported to HEAD, and committed to both HEAD and D6--1.

dww’s picture

Status: Fixed » Closed (fixed)
Issue tags: -drupal.org upgrade

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 9b087d6 on 6.x-3.x, 7.x-3.x-dev by dww:
    #386522 by dww: Fix to magic "Security update" term handling on release...
  • Commit c921035 on 6.x-3.x, 7.x-3.x-dev by dww:
    #378666 by hunmonk, dww: Fixed custom validation on the release node...
  • Commit e9dbb34 on 6.x-3.x, 7.x-3.x-dev by dww:
    #378666 by dww: More fixes to the magic "Security update" term handling...