The JS is partly of working, but the validation doesn't actually work anymore -- you can preview release nodes without the "Are you sure" checkbox selected without validation errors, you can submit, etc. When you preview, the "Are you sure" checkbox is completely lost, in fact.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | drupalorg_fix_project_security_release_confirm.patch | 2.63 KB | hunmonk |
Comments
Comment #1
hunmonk commentedyikes, lots of breakage here...
drupalorg_form_project_release_node_form_alter()was being called twice. not sure exactly what that was breaking, but it can't be good ;) i tried just removing the general form_alter manual call, but that seemed to break the js, so instead i renamed the function so that the specific form_alter wasn't called.drupalorg_security_release_form_validate()made references to $form_values instead of $form_state['values']attached patch fixes the validation on preview from my testing. i believe that the loss of the Release type terms defaults on preview is more of 6.x preview hell, and probably needs a hack in project_release module to fix properly.
Comment #2
hunmonk commentedthe loss of values on preview is now being handled over at #382634: Previewing multiselect taxonomy fields lose value on multistep node forms
Comment #3
dwwReviewed, tested, ported to HEAD, and committed to both HEAD and D6--1.
Comment #4
dwwFYI: Committed a few other fixes for this:
http://drupal.org/cvs?commit=177830
http://drupal.org/cvs?commit=177836