_filter_html_image_secure_process() ensures that images are in fact on-site images. However, FileUrlGenerator::transformRelative() does not know that images are simultaneously on www.drupal.org & new.drupal.org.

Issue fork drupalorg-3558007

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drumm created an issue. See original summary.

drumm opened merge request !420

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
Status: Active » Needs review

fjgarlin made their first commit to this issue’s fork.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Needs work

So, the code currently is not D11 compatible, but new.d.o is still on D10, for which this code is valid.

I don't think we can do the D11-hook implementation on D10, so probably what's needed now is to add the exception to phpstan and probably create a "postponed" task for when we fully move the site to D11.

We could detect the Drupal version and do one or the other depending on it, tho that'll mean extra work now.

NW so we can at least answer those questions.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#3558359: Upgrade to D11

We’ll have to stick with the D10 implementation now, and do what we can to keep track of what we need to think about when we have a chance to upgrade: #3558359: Upgrade to D11

I think I gave this enough testing to get it deployed.

  • drumm committed ac407091 on 1.0.x 
    fix: #3558007 Replace filter_filter_secure_image_alter() with our own...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

This is deployed and working.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.