The display of comments cross-posted from merge requests does not match that of standard node comments, it could use some (minor) improvement of the display. I don't know if this would be part of the same file, but it would also be useful to link the comment to the d.o user who posted the comment.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
drumm’s picture

drumm
he/him
Location NY, US
commented
Title: Improve display of cross-posted comments from merge requests » Link to Drupal users in merge request activity
Parent issue: » #2205815: Merge requests in Drupal.org issue queues?

The new parent issue has a few other improvements planned, like #3158855: Add time ago toggle to merge request activity on Drupal.org issues. So focussing this issue down on just linking the username. This wasn’t done so far, since we need a bit more data to translate GitLab users back to the correct links to Drupal.org users.

This should be doable without additional HTTP requests, we can have the original issue request add in a JS setting mapping all the commenters on the issue. We already post an issue comment on behalf of someone interacting with the merge request, if they have not already commented on the issue, for issue credit. So everyone interacting with the merge request should already be in the issue.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm

  • drumm committed 85b178d on 7.x-3.x 
    Issue #3159416: Link to Drupal users in merge request activity
  • drumm committed b4792ea on 7.x-3.x
    Issue #3159416: Move loading a node’s comments into a separate function...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed

Merge request activity now links to Drupal.org user pages.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.