Drupal.org was upgraded to 7 from the pre-profile days, and thus it was never assigned a profile. While this isn't usually an issue, it does throw errors from time to time.

We should set the profile to 'minimal' and enable it.

However, by doing that, it executes the .install file, which adds some blocks and does some other undesirable things. We really just need it enabled by adding a line in the database and setting it as the default profile.

Deployment

  • Merge 2604634-minimal-profile drupalorg branch
  • Add to drupal.org.make:
    ; Remove minimal install file so we can enable the minimal profile. Remove after drupalorg_update_7085 is ran.
; https://www.drupal.org/node/2604634#comment-10510674
projects[drupal][patch][] = "https://www.drupal.org/files/issues/2604634-remove-minimal-install-4.patch"
CommentFileSizeAuthor
#8 2604634-Add-Minimal-Profile.patch975 bytesjaperry
#6 missing_profile_dorg.jpg264.04 KBjaperry
#4 2604634-remove-minimal-install-4.patch2.35 KBjaperry

Comments

japerry created an issue. See original summary.

japerry’s picture

japerry
Location KOMK
commented
Status: Active » Needs review

Update is in hash 3e66f26a123483fa9df5146a359fecee57384c96 in the 7.x-group branch of the drupalorg module.

I have this after the panelizer patch, it'd be great to do it in that order to avoid having to rename updates. But its not a huge deal.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Needs work

well that didn't work. DB query was added but somehow status got put back to 0. I guess the other approach is to remove the install code and enable the profile normally.

japerry’s picture

japerry
Location KOMK
commented
StatusFileSize
new 2604634-remove-minimal-install-4.patch2.35 KB

Here is the patch we can include with core to remove installer, I'll try this on a new dev deployment in the morning.

drumm’s picture

drumm
he/him
Location NY, US
commented

it does throw errors from time to time

What exactly are these errors?

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
StatusFileSize
new missing_profile_dorg.jpg264.04 KB 
Error message when on the modules page locally. Should also occur when you goto the site status report page.

Notice: Undefined index: distribution_name in drupal_install_profile_distribution_name() (line 207 of /Users/japerry/Sites/da/drupal.org/htdocs/includes/install.inc).

Also happening on prod (where errors are suppressed):

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Needs review

Okay, tested this one locally and on dev and appears to work better with removing the .install file from the profile.

Hash: e160299a4e8ab2c2e343d8bd37e80bd65cdb0907

Once the update is deployed, we can remove the core hack.

japerry’s picture

japerry
Location KOMK
commented
StatusFileSize
new 2604634-Add-Minimal-Profile.patch975 bytes

Here is the install script from the 7.x-groups branch.

drumm’s picture

drumm
he/him
Location NY, US
commented

I cleaned up the patch's comments, which still mentioned the DB query approach, updated the hook_update number and committed to the branch.

Still needs testing and deployment instructions.

  • drumm committed 2aa49fd on 2604634-minimal-profile authored by japerry 
    Issue #2604634 by japerry: Set Drupal.org to the core 'minimal' profile
drumm’s picture

drumm
he/him
Location NY, US
commented
Issue summary: View changes

Adding deployment notes to the issue summary.

drumm’s picture

drumm
he/him
Location NY, US
commented
Related issues: +#1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that

I tried this out on a dev site, but it did not remove the notice. I'm left with minimal in the system table, with status = 0.

According to the core issue for this, #1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that:

work-around for current Drupal 7 users: You need to enable the profile used to install Drupal by updating the system table. For example: UPDATE system SET status=1 WHERE name='standard'; will enable the Standard profile.

  • drumm committed 2aa49fd on 7.x-3.x authored by japerry 
    Issue #2604634 by japerry: Set Drupal.org to the core 'minimal' profile
  • drumm committed 3add16f on 7.x-3.x
    Revert Issue #2604634 by japerry: Set drupal.org to the core 'minimal'...
drumm’s picture

drumm
he/him
Location NY, US
commented

I tried out UPDATE system SET status=1 WHERE name='standard'; on a fresh dev site. That removes the notice message.