Coming from #2078807: Create a separate 'Project Ownership' issue queue. New issue queue for project ownership requests exists: https://drupal.org/project/projectownership and we need to move all old/current issues there.
Patch coming soon.

CommentFileSizeAuthor
#4 2256249-4-Move-project-ownership-issues.patch1.21 KBtvn
#1 2256249-1-2-no-node-join-Move-project-ownership-issues.patch970 bytestvn
#1 2256249-1-Move-project-ownership-issues.patch1012 bytestvn

Comments

tvn’s picture

tvn commented
Status: Active » Needs review
StatusFileSize
new 2256249-1-Move-project-ownership-issues.patch1012 bytes
new 2256249-1-2-no-node-join-Move-project-ownership-issues.patch970 bytes

Patch for hook_update_n attached. Tested on sprint7 and sprint8 dev sites.

The reason for INNER JOIN node in the query of the first patch is orphaned data in the dev site database. There were lots of orphaned rows in the field_data tables, which had no corresponding rows in the node table, node_load was failing as a result and I wasn't able to test the patch.

The second attached patch has no INNER JOIN node in case you prefer to use this one on production.

Can we prevent email notifications from going out while running this update? E.g. by running it from the 'System Message' user.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

http://cgit.drupalcode.org/project_issue/tree/project_issue.module#n309 has examples.

Use nodechanges_comment_attributes to specify no email.

Use nodechanges_uid to make it come from System Message, who is variable_get('project_issue_followup_user', 0).

drumm’s picture

drumm
he/him
Location NY, US
commented

The JOIN is okay in production. I'd rather run tested code than anything else.

Finding the nodes with EntityFieldQuery would be ideal, but not required for an update function that will never run more than once.

tvn’s picture

tvn commented
Status: Needs work » Needs review
StatusFileSize
new 2256249-4-Move-project-ownership-issues.patch1.21 KB

Added nodechanges stuff to specify System Message user and no email.

Tested on https://sprint1-drupal.redesign.devdrupal.org/project/issues/projectowne...
e.g. https://sprint1-drupal.redesign.devdrupal.org/node/2220433

Issue update seem to be working. I was not able to test no email part however, since we now send issue queue notifications via Jenkins job.

  • Commit 18fceb3 on 7.x-3.x authored by tvn, committed by drumm: 
    #2256249 Move 'Project ownership' issues to the new queue
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Committed & deployed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 18fceb3 on 7.x-3.x, 7.x-3.x-dev authored by tvn, committed by drumm: 
    #2256249 Move 'Project ownership' issues to the new queue