Right now when you upload a file in the embedded comment form, after the upload is complete the form re-collapses causing you to think your file didn't upload. It's there, in the table, but hidden. That shouldn't happen.
When you check $form_state for whether a new file was uploaded in order to keep the fieldset open, then it blows the size of the table across the entire width. DyanneNova looked into this and found there was some weird hard-coded styling via JS that was causing this.
This feels like a deployment-blocker for #2159409: [Meta] Implement first iteration to improve issue queue workflow to me. Ranking as a major bug.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screen Shot 2013-12-29 at 6.09.42 AM.png | 64.34 KB | webchick |
| #1 | 2164105-filecollapse-1.patch | 1.03 KB | japerry |
Comments
Comment #1
japerryHere is a first attempt at a patch. Works on my local, and didn't observe the JS issue DyanneNova or Webchick saw.
Comment #2
japerryComment #3
webchickYeah, here's what happens to me on localhost with that patch. :( (Chrome + Firefox)
However, I witnessed japerry being unable to reproduce this on his laptop. I think we need one more pair of eyes to figure out if this is a local environment issue one way or another. (And/or, we could try just committing it to master and deploying it to dev and see what happens.)
Comment #4
webchickYeah, screw it, let's just do that. :) Much easier for front-end developers to fix the bug if they can actually see it.
Committed and pushed to master, marking this as a dupe since we'll just handle it as part of #2159813: Display parts of the issue edit form instead of the comment form on issue pages.