Closed (fixed)
Project:
Drupal.org customizations
Version:
6.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2011 at 08:04 UTC
Updated:
23 May 2014 at 18:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
webchickHere's the conservative approach that just does this for documentation.
Comment #2
sunI didn't really study the surrounding code, but based no the visible fragment, the change makes sense and seems to be correct.
Comment #3
webchickdww asked about the origin of this code, and it came from #379072: Attachments are Disabled on Book Pages. The intent was to limit file uploads to only the docs team, since only the docs team has access to the input format to post images. However, now that this restriction has been lifted, it makes sense to lift it for everyone else.
The patch doesn't have enough context to adequately eyeball, so here's the entire relevant chunk of code:
Comment #4
jthorson commentedCouldn't apply the patch on rfay.redesign.devdrupal.org, but that's likely due to it being an old codebase.
Manually made the change, and the file attachment box appeared at /node/add/book, while it wasn't there before the change.
Comment #5
dwwThanks folks. Committed, pushed, and deployed live.