Using master branch. Not sure what happened there; the report looks great in 0.4.

Report missing elements

CommentFileSizeAuthor
Screen Shot 2014-10-05 at 1.29.32 PM.png44.92 KBwebchick

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

The report handling changed in master. Most plugins need to be updated, but I was focused on tests. ;)

  • phenaproxima committed 9269a10 on master 
    Restored coloring the analysis report. (Issue #2351035)
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs work

Looks closer now; http://cgit.drupalcode.org/pants/plain/upgrade-info.html is a copy of the report as it looked in 0.4. Differences:

- (!) There are about half as many things flagged as there were before (that seems worth looking into). For example, nothing there anymore about CTools plugins, variable_*, etc.
- "Many common functions" and a few others used to be yellow, now they're red
- "Flagged by plugin name" text is missing.
- "Files affected" prints even when it doesn't have any info about that.
- Where there were multiple "files affected" only one is showing.
- "<kbd>" tags are escaped in documentation link titles, e.g. "Many common dependencies have moved into core."

Possibly some others, but that's what I caught on a quick "visual diff."

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +demo blocker
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

This looks good now. I think there are still some minor differences but we can sort 'em out individually if needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.