Reviewed & tested by the community
Project:
DrupalGap
Version:
8.x-2.x-dev
Component:
Module Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Aug 2018 at 17:53 UTC
Updated:
28 Aug 2018 at 21:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alonaoneill commentedI uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!
Comment #3
tyler.frankenstein commented@alonaoneill Thank you for the patch. I'm curious, where did the field, filter, user, and system dependencies come in from? I could see user user being a good inclusion, but I am not sure that field, filter and system are required for every instance out there. Your thoughts?
Comment #4
volkswagenchick@tyler.frankenstein - Looks like the other projects are listed on the Extend page for this project. Screenshot attached.
Code looks good. All the projects listed as dependencies on the Extend page for the module are now listed as dependencies. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Comment #5
tyler.frankenstein commentedThank you for confirming @volkswagenchick, that makes sense. Everything looks good, I went to apply it and noticed it is for the 8.x-2.x branch, when the 8.x-1.x is the most current branch (my fault for leaving this stale 8.x-2.x branch that never came to be).
I'd be happy to apply this and give the attribution to you both on the 8.x-1.x branch, but mainly want to make sure you're using the correct version of the module and aren't having any other problems. Please advise, thanks.
Comment #6
tyler.frankenstein commentedComment #7
alonaoneill commentedI uploaded a patch that corrects the dependency namespacing in the .info.yml file.
8.x-1.x version
Thanks!
Comment #8
volkswagenchickPatch applied to the 8.x-1.x via simplytest.me. Thanks for the feedback @tyler.frankenstein.
Code still looks good and aligns with dependency namespacing standards. Thanks!
Marking as RTBC