According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new459 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

tyler.frankenstein’s picture

@alonaoneill Thank you for the patch. I'm curious, where did the field, filter, user, and system dependencies come in from? I could see user user being a good inclusion, but I am not sure that field, filter and system are required for every instance out there. Your thoughts?

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new26.49 KB

@tyler.frankenstein - Looks like the other projects are listed on the Extend page for this project. Screenshot attached.

Code looks good. All the projects listed as dependencies on the Extend page for the module are now listed as dependencies. The dependency namespacing aligns with Drupal documentation standards.

Patch applied via simplytest.me

Marking as RTBC

tyler.frankenstein’s picture

Thank you for confirming @volkswagenchick, that makes sense. Everything looks good, I went to apply it and noticed it is for the 8.x-2.x branch, when the 8.x-1.x is the most current branch (my fault for leaving this stale 8.x-2.x branch that never came to be).

I'd be happy to apply this and give the attribution to you both on the 8.x-1.x branch, but mainly want to make sure you're using the correct version of the module and aren't having any other problems. Please advise, thanks.

tyler.frankenstein’s picture

Status: Reviewed & tested by the community » Needs work
alonaoneill’s picture

Status: Needs work » Needs review
StatusFileSize
new564 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
8.x-1.x version
Thanks!

volkswagenchick’s picture

Status: Needs review » Reviewed & tested by the community

Patch applied to the 8.x-1.x via simplytest.me. Thanks for the feedback @tyler.frankenstein.

Code still looks good and aligns with dependency namespacing standards. Thanks!

Marking as RTBC