Problem/Motivation

This repo has a file called recommended-add-ons.yml but it should be recommended.yml

Issue fork drupal_cms_site_template_base-3571414

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

pameeela opened merge request !10

pameeela’s picture

pameeela commented
Status: Active » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Why?

Half the purpose of this starter kit is documentation, and recommended-add-ons.yml is a much clearer name. There is no reason why it can't be named recommended-add-ons.yml in production.

I think this should be wontfixed.

pameeela’s picture

pameeela commented

For consistency, in Drupal CMS it’s recommended.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

If you feel really strongly about it, we can change it. But I don't think we need to be consistent with Drupal CMS. I'd argue that we mis-named the file in Drupal CMS, and in a starter kit that needs to be super clear and well-documented, we should go for the better, clearer name.

pameeela’s picture

pameeela commented

Thought more about this and I do think it makes sense to change it now, before any site templates are live. The main reason (besides consistency) is that it locks us in to the add-ons terminology in a way that I'm not sure is a good idea. We could update it later with redirects or something? But that will get messy.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Fix recommended yml file » Rename recommended-add-ons.yml to recommended.yml

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Fixed

Merged into 1.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.