There were some missing t()s we found as we were going through. This patch adds them back in. It also removes the t() around 'Drupal' in aggregator module's site_name variable get, since there is nowhere else in core where that is translated.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | t_4.patch | 7.1 KB | RobRoy |
| #3 | fix-ts_1.patch | 7.09 KB | webchick |
| #2 | fix-ts_0.patch | 7.09 KB | webchick |
| fix-ts.patch | 11.23 KB | webchick |
Comments
Comment #1
drumm( ! ) Parse error: syntax error, unexpected ';' in /home/drumm/drupal/drupal/C-HEAD/includes/theme.inc on line 1021
Comment #2
webchickWell that's no good, is it? ;)
Here's a re-roll. This does not include a couple of the changes (aggregator and drupal.module, I think), which are/were covered by other patches.
Comment #3
webchickJust a re-roll to get rid of offsets.
Comment #4
RobRoy commentedTook the spaces out of t() as we'll always want those out of there so someone doesn't accidentally remove them then have text smushed together? Also, put double quotes around the string with the single quote as that's the direction we're going now right? Super minor changes.
Comment #5
webchickYeah, Neil wanted each different change in a separate patch, but this one is pretty small and easy to review for the other minor changes you included, so I think it's ok. Looked it over. Looks good. Tentatively marking RTBC.
Comment #6
RobRoy commentedYeah, I was thinking that I was mixing my meat and dairy together. Thanks webchick!
Comment #7
dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
(not verified) commented