path_get_admin_paths() is executed at each (non-cached) page view. As it involves a module_invoke_all() call which implementations may be relatively heavy (preg matches and so on), IMO it could db-cache the result. Unless obviously the result may vary at each request which I don't think.

I'll try to provide a patch and some benchmarks asap.

CommentFileSizeAuthor
#3 896570-cache--path-get-admin-paths.patch976 byteserikwebb
#1 896570-cache-path-get-admin-paths.patch949 byteserikwebb

Comments

erikwebb’s picture

erikwebb commented
Status: Active » Needs review
StatusFileSize
new 896570-cache-path-get-admin-paths.patch949 bytes

Whether this is a significant improvement or not, I'll leave that up to someone more knowledgeable. I've attached a patch to add a new path:admin_paths cache variable.

Status: Needs review » Needs work

The last submitted patch, 896570-cache--path-get-admin-paths.patch, failed testing.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review
StatusFileSize
new 896570-cache--path-get-admin-paths.patch976 bytes

Forgot to create diff from the root folder.

Status: Needs review » Needs work
Issue tags: -Performance

The last submitted patch, 896570-cache--path-get-admin-paths.patch, failed testing.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review
Issue tags: +Performance

#3: 896570-cache--path-get-admin-paths.patch queued for re-testing.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Closed (won't fix)

Any expensive code that runs in this hook can do its own caching IMO

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Closed (won't fix) » Closed (duplicate)

Marking duplicate of #1032700: Add caching to hook_admin_paths().