This parameter should be optional. There are many occasions -- e.g., contextual link that goes to a (static) config page -- where the function call would not require $args.

CommentFileSizeAuthor
#13 make-args-optional-in-menu_contextual_links-895756-13.patch447 bytesRajender Rajan
#1 make-args-optional-in-menu_contextual_links-895756.patch604 bytescrookednumber

Comments

crookednumber’s picture

crookednumber commented
Status: Active » Needs review
StatusFileSize
new make-args-optional-in-menu_contextual_links-895756.patch604 bytes

Patch.

crookednumber’s picture

crookednumber commented
Version: 7.x-dev » 8.x-dev

Changing to D8.

crookednumber’s picture

crookednumber commented

Will re-roll for D8 -- and the impending architecture change on Nov. 1.

http://groups.drupal.org/node/179649

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

#1: make-args-optional-in-menu_contextual_links-895756.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, make-args-optional-in-menu_contextual_links-895756.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: crookednumber » Unassigned
Issue summary: View changes
crookednumber’s picture

crookednumber commented
Assigned: Unassigned » crookednumber

I'm in no way wedded to this issue, but it strikes me as rude to change assignment on an issue without providing a reason.

mgifford’s picture

mgifford
he/him
Primary language English
commented

@CrookedNumber - the reason is pretty simple. This issue isn't moving ahead.

It was 3 years since you last touched this issue. Now it could be that nobody would have jumped in to roll a patch anyways, but issues are generally assigned to people when they are going to work on it.

Nov 1, 2011 came and went. You may or may not want to re-roll it. At this stage in the release cycle, either re-roll the patch or unassign yourself.

crookednumber’s picture

crookednumber commented

@mgifford, I appreciate the work you're doing to un-assign all these issues. But just a re-assign comes across as quite abrupt -- that's all I'm saying.

Might I suggest adding some simple boilerplate: "There has been no new work on this in quite some time. So I'm assuming it's been abandoned. Sincere apologies if it hasn't." Surely no one would take offense at something like that.

mgifford’s picture

mgifford
he/him
Primary language English
commented

That's a good suggestion. Sorry it rubbed you the wrong way. I can work on a simple statement like that in the future.

Any ETA on a fresh patch?

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: crookednumber » Unassigned

A bit cheeky but - There has been no new work on this issue in quite some time. So I'm assuming the person assigned is no longer being actively pursuing it. Sincere apologies if this is wrong.

alx_benjamin’s picture

alx_benjamin commented
Version: 8.0.x-dev » 7.x-dev

Method mentioned in the patch, menu_contextual_links(), does not exist in D8.
But it is in D7.
So assigning the issue to D7 branch

-------------------------------------------------
Sponsored by http://reallifedesign.co.uk/

Rajender Rajan’s picture

Rajender Rajan commented
StatusFileSize
new make-args-optional-in-menu_contextual_links-895756-13.patch447 bytes
Rajender Rajan’s picture

Rajender Rajan commented
Status: Needs work » Needs review

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.