Can't upload .ico favicon

Looks okay to the eye, but why are you changing the form element the error is set on?

- form_set_error('logo_upload', t('The favicon could not be uploaded.'));
+ form_set_error('favicon_upload', t('The favicon could not be uploaded.'));

If that is a separate bug, then it's a separate bug ;)

That does still need a separate issue though, sorry. One issue per problem.

Updated patch to get this issue resolved.

I see no reason why we should support this by default, it is not a commonly used format - by this same argumenting we should also support .icns

This is referring to favicons not logos. Prior to IE 8 there is no other file format supported by all browsers, as was noted in the original bug report (http://en.wikipedia.org/wiki/Favicon#Browser_support).

ico is by far the most common format for favicons. Nearly 30% of people browsing the web can only see favicons in ico format. (See here http://en.wikipedia.org/wiki/Template:Msieshare1)

Sorry, but I see no reason for that to be a supportive argument. Sure, it was supported by all but used by almost none? Why would it be a common use case to upload favicons? After all you don't do that through the interface.

Adding a exstention, is not a bug - it works perfectly, you can add it yourself. Even adding something like JPG would be a feature request.

Question is: does someone who can handle creating an .ico file find the setting to add the .ico extension to the allowed formats.

If not, I'd be supportive of allowing the .ico Format, as it is indeed the default format for Favicons and there are are applications out there that do nothing but create Favicons. I don't see a way allowing another file format is bound to introduce a lot of followup issues.

I'll try again. This is referring to the "Upload icon image" functionality that is part of core Drupal (See attached screenshot).

The upload process already supports " jpg jpeg gif png txt doc xls pdf ppt pps odt ods odp" this is simply trying to get ico added to that list. For what it is worth only the first 4 of those formats are even supported favicon formats. The other formats won't work no matter what your browser. To be fully correct that list should be "ico png gif jpg jpeg apng svg" (The attached patch implements this list.)

The ico file format is the most popular format and is used by most major websites. (Drupal.org, google.com, facebook.com, wikipedia.com, etc. Here is a map of the internet made this year from the favicons of the top 1,000,000 websites.)

If you don't feel the "Upload icon image" feature should be in Drupal core please create an issue to have it removed. This issue is just trying to get the existing feature to work correctly for the vast majority of users.

I never knew we had such a feature, thats soo weird. Now you are making sense, I thought you where arguing this for image field in article page - unless I am totally missing it, you are never mentioning its for "this".

Fixes a bug, so yes.

Looks like we're using a tab instead of a space. This will need a quick re-roll but is otherwise RTBC.

Committed to CVS HEAD. Thanks.