Is it just me or do the comment links (maybe on nodes as well, I cant recall) look like they're floating around in space a bit too much?

What happens when the links wrap, say if I have Flag & Mollom installed and have more than a few Links - do they wrap back hard to the left? Wouldn't these be better left or right aligned?

As a side note I also think the white space above the comment title is a bit wasteful and looks odd since the new proposed comment #id things is above the title.
bartik-comments.png

Comments

Bojhan’s picture

The gap is weird, the rest is just good spacing. Lets just have a patch that left aligns them.

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new3.18 KB
new574 bytes

Patch + screenshot.
Investigating rtl...

aspilicious’s picture

StatusFileSize
new590 bytes

Here is a "better" patch.

aspilicious’s picture

RTL support

aspilicious’s picture

the links should be reverted in rtl but that is another issue.

Status: Needs review » Needs work

The last submitted patch, bartik-comment-links-alignedv3.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
StatusFileSize
new1.08 KB

d$é!# windows endings....

bleen’s picture

Status: Needs review » Reviewed & tested by the community

This looks good ... improvement == true :)

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.