Fixing newlines

CommentFileSizeAuthor
#2 newline_bootstrap_inc_v2.patch2.96 KBaspilicious
newline_bootstrap_inc.patch2.71 KBaspilicious

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks OK to me. This could be re-wrapped, or perhaps re-punctuated/phrased slightly to make it one sentence:

+ *
  * @return
  *   TRUE if the resource was found, FALSE if not.
  *   NULL if either of the REGISTRY_* constants is passed in as $type.

Actually, how about this:

TRUE if the resource was found, FALSE if the resource was not found, or NULL if either of the REGISTRY_* constants is passed in for $type.

aspilicious’s picture

aspilicious commented
StatusFileSize
new newline_bootstrap_inc_v2.patch2.96 KB

Final reroll?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Postponed

postponed as per http://drupal.org/node/855410#comment-3208874 and http://drupal.org/node/855324#comment-3208840

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Postponed » Closed (duplicate)

Closing as duplicate:
http://drupal.org/node/855170#comment-3794950