As the message can be used only when the e-mails sent are one, the string should be 1 e-mail sent during this test..

CommentFileSizeAuthor
#5 812620_placeholder_and_others.patch944 bytesavpaderno
#1 812620_placeholder.patch982 bytesavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new 812620_placeholder.patch982 bytes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

I forgot to change the status.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Patch applies cleanly and makes sense.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work

format_plural does not want the strings already wrapped in t(). I think we should fix this here.

I wonder whether it is allowed to change the placeholder at this time and use @count instead.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 812620_placeholder_and_others.patch944 bytes

I re-rolled the patch as suggested by dawehner.
I changed the type of placeholder too; as already a string is being changed, I don't see any problem in modifying the placeholder too.

dries’s picture

dries commented
Status: Needs review » Fixed

Good catch. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.