The default password does not have a max length. The current theme in form.inc adds an empty maxlength attribute.
The code validator I am using complains about the empty attribute.

CommentFileSizeAuthor
#6 form_1.patch1012 byteswpd
form.patch.txt1.11 KBwpd

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work

I think this might be better to fix in system_elements, by giving the password element a default #size.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

And I meant #maxlength. :P

wpd’s picture

wpd commented
Status: Needs work » Needs review

I thought about that, but I disagree. The themeing function is broken. It is adding an optional atrtibute with an invalid value.

PS: Here is a related issue, but not quite the same.
http://drupal.org/node/79580

killes@www.drop.org’s picture

killes@www.drop.org commented
Version: 4.7.3 » x.y.z

moving to cvs, willback port if committed.

dries’s picture

dries commented
Status: Needs review » Needs work

I agree with wdp that the theme function needs to be fixed.

Unfortunately, the patch doesn't apply against CVS HEAD. Care to re-roll against CVS HEAD?

wpd’s picture

wpd commented
Status: Needs work » Needs review
StatusFileSize
new form_1.patch1012 bytes

Patch re-rolled against HEAD

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD. Thanks a bundle.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: x.y.z » 4.7.x-dev
Status: Closed (fixed) » Patch (to be ported)

Marking to be ported. See http://drupal.org/node/92858 for discussion.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Patch (to be ported) » Fixed

used original patch, fixed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)