Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
filter.module
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
29 Apr 2010 at 00:05 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sunGlad to see that this is covered by tests :)
Comment #3
hingo commented"Read-only review:"
This was discussed/discovered in #340776: URL filter does not urldecode() the URL for link text. Everyone seems to agree title attribute should be removed.
The change is simple and risk free, it only affects html output.
By reading, the patch looks ok.
Note: I'm running for work and did not have time to actually apply the patch and test it "with my own hands". Leaving status unchanged so someone else can do that. Except for this detail, I support swiftly committing the patch.
Comment #4
Everett Zufelt commentedDidn't have time to test the patch. But +1 conceptually on removing the title attribute from an accessibility perspective. It really serves no purpose to repeat the URL in the title attribute.
Comment #5
sunThanks! So let's go.
Comment #6
hingo commentedCall me conservative, but shouldn't at least one person (apart from yourself) actually apply the patch first?
I've seen enough of silly reviews where the patch even had PHP syntax errors, I wouldn't want to become one of those reviewers myself. That's why I said, I support this, but didn't really test it for real myself.
Comment #7
mgiffordI refreshed my sandbox & applied this patch here - http://drupal7.dev.openconcept.ca/
It applied with no difficulty. I'd have liked to have had a simple way to test, but in looking over the code but it looks very straight forward.
Putting this back to RTBC.
Comment #9
dries commented#2: drupal.filter-url-title.2.patch queued for re-testing.
Comment #10
dries commentedCommitted to CVS HEAD. Thanks.