Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Apr 2010 at 04:47 UTC
Updated:
6 May 2010 at 23:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
jhodgdonHere's a patch
Comment #2
aspilicious commentedDELETED COMMENTS
I was wrong, hooks have to be in the imperative form...
Comment #3
aspilicious commentedComment #4
aspilicious commentedAfter editing #2
Comment #5
puregin commentedI'm wondering if dropping the table in the example for hook_field_storage_purge_field() is common semantics? It seems a bit radical.
I'd probably also do without the intermediate variables. Do we need to describe @return values?
Other than that, looks good!
Comment #6
jhodgdonThat example is taken directly from code in core.
There are no return values, so we should not have a @return. Please read the standards doc, which I've given you the link to on other issues. Thanks!!
Comment #7
blg@bgreenaway.com commentedI concur with puregin#5, looks good!
As per standards agreement (which I hear you two have resolved now ;) no need for @return in this case - so the hook is documented perfectly and ready to commit.
Please commit.
Comment #8
dries commentedCommitted to CVS HEAD.