Incorrect search path for available image toolkits.

--- image.inc	2006-08-05 04:58:26.000000000 -0400
+++ image_old.inc	2005-12-14 14:06:42.000000000 -0500
@@ -7,7 +7,7 @@
  * @return An array of toolkit name => descriptive title.
  */
 function image_get_available_toolkits() {
-  $toolkits = file_scan_directory('modules/image/', 'image\..*\.inc$');
+  $toolkits = file_scan_directory('includes', 'image\..*\.inc$');
 
   $output = array();
   foreach ($toolkits as $file => $toolkit) {
CommentFileSizeAuthor
#1 image.inc_5.patch437 bytestheque
image.inc_4.patch437 bytestheque

Comments

theque’s picture

theque commented
StatusFileSize
new image.inc_5.patch437 bytes

Oops...
Sorry vice versa :)

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Needs review

No one has reviewed this.

beginner’s picture

beginner commented

How to reproduce the bug?
Why version 4.7.3: has this been fixed in HEAD already?

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Closed (won't fix)

We expect .inc files in the /includes directory. Just copy them there. Image.module might want to have its install instructions updated.

walkah’s picture

walkah commented

So, here's the deal with this one... the issue with changing the search path to look in modules/image is that - while yes this is where the alternate tookit(s) are currently stored... there was original reluctance on relying on having image.module installed... hence it searches includes.

searching modules/image gives a good "out of the box" experience in that... if image is installed ... imagemagick would just work...

of course, there's always putting image.module in core. *snicker*

I will make sure that image module's documentation makes this clear.