I spent 40 minutes finding out why Seven has 'add to shortcuts' links besided page titles and Stark and Garland have not. Turns out this is a feature that gets enabled throug a theme's info file:

settings[shortcut_module_link] = 1

Since core comes with shortcuts module enabled in the default install profile I think all core themes should support it out of box as well. Attached patch adds the above line to Garlands and Starks info files but doesn't yet have the CSS fixes for the mess that creates.

Would you agree core themes should expose this functionality by default?

CommentFileSizeAuthor
#1 enableshortcuts.patch943 bytesyoroy

Comments

yoroy’s picture

yoroy commented
Status: Active » Needs review
StatusFileSize
new enableshortcuts.patch943 bytes

Uhm yeah, so patch.

aspilicious’s picture

aspilicious commented

We disabled it, cause it's a mess and we only need a shortcut toolbar for maintainers and they are going to use seven theme...
I don't think we have to enable it...

yoroy’s picture

yoroy commented

Ah, I was thinking I remembered seeing those links in Garland sometime ago. This sounds like swiping the mess under the rug instead of fixing it though. If it takes me 40 minutes to figure this out then I have to wonder how others are going to do it.

Got a link to the issue that removes them?

aspilicious’s picture

aspilicious commented

I try to find it, but it was something as make add shortcut links a theme feature

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

+1 for adding shortcut links.

I could not see settings[shortcut_module_link] = 1 in any version garland.info. http://drupalcode.org/viewvc/drupal/drupal/themes/garland/garland.info?v... ?

#674394: The add/remove shortcut buttons look bad and don't appear in most themes besides Seven is the way (or related) to fix this.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Closed (duplicate)

looks like this is either "won't fix" or a duplicate.