This may be a duplicate issue, but I couldn't find it anywhere...

When you go to /admin/structure/block it should default to the current default theme. Right now it defaults to Garland.

CommentFileSizeAuthor
#15 738958.patch925 bytesbleen
#11 blocks_page.patch1.57 KBbleen
#9 blocks_page.patch1.57 KBbleen
#3 blocks_page.patch1.57 KBbleen

Comments

aspilicious’s picture

aspilicious commented

Nice catch, took me 4 minutes to understand what you were talking about.

To make this clear for people like me:
- got to /admin/structure/block
- watch the secondary tabs
- that one will always use garland as active tab

What has to be done:
- If you go to that page, redirect to admin/structure/block/list/$currentTheme

bleen’s picture

bleen commented
Title: Menu cache needs to be rebuilt when the default theme is changed » /admin/structure/block defaults to garland no matter what theme you have selected

note that if you clear the cache after switching themes, then everything works as expected

EDIT: If you're just coming to this issue, you can probably skip to #14

bleen’s picture

bleen commented
Status: Active » Needs review
StatusFileSize
new blocks_page.patch1.57 KB

This patch does what aspilicious suggests in #1

The root of the problem is that the $default_theme is getting cached in the block_menu function.

Status: Needs review » Needs work

The last submitted patch, blocks_page.patch, failed testing.

aspilicious’s picture

aspilicious commented

if #2 is true we might have a lucky day cause I think there is an issue somewhere bout clearing cash when switching themes

bleen’s picture

bleen commented

@aspilicious: any idea what issue that might be happening in? I dont see anything anywhere

aspilicious’s picture

aspilicious commented

Damnit can't find it... :( I don't have time this weekend, maybe I'm just hallucinating

bleen’s picture

bleen commented
Status: Needs work » Needs review

#3: blocks_page.patch queued for re-testing.

bleen’s picture

bleen commented
StatusFileSize
new blocks_page.patch1.57 KB

Test bot does not seem to want to re test .. here is that patch again because I cant fathom why it failed on the locale module the first time.

Status: Needs review » Needs work

The last submitted patch, blocks_page.patch, failed testing.

bleen’s picture

bleen commented
Status: Needs work » Needs review
StatusFileSize
new blocks_page.patch1.57 KB

now it's complaining about irrelevant block tests ... I dont get this test fail locally. Gonna try testbot one more time because it loves me and if I say nice things about it, it will behave

Status: Needs review » Needs work

The last submitted patch, blocks_page.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

subscribing

bleen’s picture

bleen commented
Title: /admin/structure/block defaults to garland no matter what theme you have selected » Menu cache needs to be rebuilt when the default theme is changed
Status: Needs work » Active

Discussed this issue in IRC with tha_sun and it seems this is a symptom of the larger problem that the menu_cache needs to get rebuilt when the default theme is changed...

bleen’s picture

bleen commented
Title: /admin/structure/block defaults to garland no matter what theme you have selected » Menu cache needs to be rebuilt when the default theme is changed
Status: Active » Needs review
StatusFileSize
new 738958.patch925 bytes

This is an uber-simple patch to rebuild menu cache upon changing the default theme .... seems to work well.

I tested by:
- got to /admin/structure/block
- watch the secondary tabs
- change default theme
- got back to /admin/structure/block & make sure secondary tabs changed

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

That test procedure needs to be turned into a real test now ;)

aspilicious’s picture

aspilicious commented

AHA I found it!

crosslinking: #690544: Blocks admin (admin/structure/block) requires menu_rebuild() to display settings for current theme

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Closed (duplicate)

OK, so this (yet another) duplicate of #690544: Blocks admin (admin/structure/block) requires menu_rebuild() to display settings for current theme, so I'm marking it as such. The solution in that issue is identical to this one.