How to replicate:

0) Ensure you have both the overlay and the toolbar Enabled.
1) Disable the toolbar from within the overlay.
2) Notice that the toolbar is still availble, and can still be used.
3) Click the Home link.
4) Notice that the toolbar has "suddenly" disappeared.

Comments

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal

This is annoying, but disabling toolbar and keeping overlay enabled isn't going to happen incredibly often (perhaps vice-versa :p), and it doesn't stop you working with the site.

lelutin’s picture

lelutin commented

@alexanderpas
This is caused by the fact that the overlay is full-AJAX and does no page refresh as long as you are still working with the overlay. This behaviour is inherrant in the overlay implementation. It's not a bug in terms of breakage but it is a small annoyance of the "wtf" type for usability.

Bojhan’s picture

Bojhan commented

Actually not that sure @catch - every admin_menu user is going to do that.

David_Rothstein’s picture

David_Rothstein commented
Title: Delayed response when disabling modules from the overlay. » Disabling the toolbar module from inside the overlay doesn't remove the toolbar until the next page load

I think this is definitely a bug and not at all inherent in the overlay implementation. It is true that the overlay uses AJAX, but it does so in a way that intentionally allows certain other regions of the page (including the toolbar region) to automatically be updated via AJAX when they change. For example, if you are in the overlay and add a shortcut, or if you rearrange the menu items in the top level of the toolbar, those currently get updated automatically - it does not require a new page load.

It sounds like this one is just a pathological case. If I had a guess, it might be because the toolbar module itself is the one declaring that its region of the page should be available to update via AJAX - so that information goes away when the module is disabled. Or it could just be part of the general cache clearing mess that occurs in Drupal 7 right now whenever a module is enabled or disabled. Hard to say :) I think it should be possible to fix this though.

casey’s picture

casey commented

Crosslinking with #655722: Changes made in an overlay session are not reflected when the user closes the overlay; that might be a solution.

alexanderpas’s picture

alexanderpas commented

I set this initial on critical, as in my opinion, D7 can't be released with this usability bug.

casey’s picture

casey commented

Currently the toolbar is being removed, the overlay displacement is however not updated correctly.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Actually this is somewhat comical...

In D7.0:

Enable both Overlay and Toolbar modules.
Disable Toolbar. Note that it remains in the page.
Refresh the page in your browser. Note that the toolbar is now gone.
Re-enable the Toolbar module. The toolbar does not appear. I guess you didn't really want it anyway...
Hit refresh and it appears.

Note that none of this applies if you turn off Overlay.

Status: Active » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.