This might've been a side-effect of #563390: Seven theme lacks formatting on common html elements such as lists, paragraphs & <code>:

Ick!

CommentFileSizeAuthor
#5 679096.patch474 byteseclipsegc
#4 bad_layout.png10.37 KBaspilicious
#3 bad_layout.png3.1 KBaspilicious

Comments

mrfelton’s picture

mrfelton commented

Yes, I believe this was caused by my patch. Should dashboard.module should provide it's own css for this special case, or should the fix should be included in the main style.css?

EDIT: dashboard module already has it's own css, so I'll add a fix to that Just need to remove the margin from those h2s I think

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Well. Be careful about fixing it in dashboard.css. That takes effect for *all* themes.

aspilicious’s picture

aspilicious commented
StatusFileSize
new bad_layout.png3.1 KB

Not done with this ;)
See attachment!

aspilicious’s picture

aspilicious commented
StatusFileSize
new bad_layout.png10.37 KB

Oooor this one...

eclipsegc’s picture

eclipsegc commented
StatusFileSize
new 679096.patch474 bytes

Here's a fix for the seven theme.

eclipsegc’s picture

eclipsegc commented
Assigned: Unassigned » eclipsegc
Status: Active » Needs review
aspilicious’s picture

aspilicious commented

This only fix the first issue do i need te open 2 different issues for my problems?

eclipsegc’s picture

eclipsegc commented

@ aspilicious:

Yeah, it's kind of frowned upon when you try to hijack one issue to fix other problems. I don't understand what's the matter with the second screen shot, but I have 2 potential fixes for the first. Post a link to that issue here for me, and I'll try to weigh in on it and get you a fix.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Awesome, thanks! I confirm this fixes the bug. Committed to HEAD. :D

@aspilicious: If there are a lot of follow-up fixes for the old patch, let's re-open the other issue. I just wanted to get this one out of the way since it's definitely wrong and we have an alpha next week omg omg omg.

aspilicious’s picture

aspilicious commented
Status: Fixed » Needs review

in the second picture look at the black dot in the middle of the circle but i think they (1 and 2) are related.
We will start with the first one...

==> #679326: Dragging "User menu" block into Dashboard looks oooglay

casey’s picture

casey commented
Status: Needs review » Fixed

Both issues aspilicious mentions are fixed elsewhere.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.