When you look at search settings, its easy to spot the odd one in the crowd. Active search modules has no fieldset around it, where it should have. It seems this was forgotten in the initial commit.

CommentFileSizeAuthor
#10 searchadminfieldset.patch1.06 KBcasey
#6 searchadminfieldset.patch845 bytescasey
#1 activesearchmodules_before.png5.33 KBBojhan
#1 activesearchmodules_after.png8.27 KBBojhan
#1 add.fieldsetactivesearch.patch1.7 KBBojhan

Comments

Bojhan’s picture

Bojhan commented
Status: Active » Needs review
StatusFileSize
new add.fieldsetactivesearch.patch1.7 KB
new activesearchmodules_after.png8.27 KB
new activesearchmodules_before.png5.33 KB

activesearchmodules_before.png

After

activesearchmodules_after.png

Status: Needs review » Needs work
Issue tags: -Usability

The last submitted patch, , failed testing.

Status: Needs work » Needs review

Re-test of from comment #2391430 was requested by @user.

Status: Needs review » Needs work
Issue tags: +Usability

The last submitted patch, , failed testing.

casey’s picture

casey commented
StatusFileSize
new searchadminfieldset.patch845 bytes

Reroll + small change:

$form['search_active_modules']['options'] isn't going to work with variable_get('search_active_modules')

should be:

$form['search_active_modules']['search_active_modules']

casey’s picture

casey commented
Status: Needs work » Needs review
Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Works

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

It's a bit unorthodox to repeat ourselves repeat ourselves that way. ;) I worry it's going to create confusion for developers trying to read this and suss out what the variable name is.

Can we make the first index just 'active' instead of the full name of the variable?

casey’s picture

casey commented
Status: Needs work » Needs review
StatusFileSize
new searchadminfieldset.patch1.06 KB
Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Usability

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.