This is an offshoot of #552620: [meta-issue] Rewrite descriptions of content types UI which was a monster patch...

This patch improves the UI text on body field label and submission guidelines at admin/structure/types/manage/[content type]

CommentFileSizeAuthor
#17 after614316_17.png8.74 KBlisarex
#17 614316_17.patch617 byteslisarex
#14 614316_13.patch594 byteslisarex
#14 614316_13.png7.6 KBlisarex
#12 614316_11.patch593 byteslisarex
#7 cckui-614316-6.patch842 bytesredndahead
#5 cckui_614316_5.patch611 byteslisarex
#2 afterBodyLabelSubmissionGuildelines.png28.45 KBlisarex
#2 beforeBodyLabelSubmissionGuildelines.png27.55 KBlisarex
#1 cckui_614316.patch1014 byteslisarex
#1 body_field_label.png5.82 KBlisarex
#1 submission_guidelines.png11.5 KBlisarex

Comments

lisarex’s picture

lisarex commented
Status: Active » Needs review
StatusFileSize
new submission_guidelines.png11.5 KB
new body_field_label.png5.82 KB
new cckui_614316.patch1014 bytes
lisarex’s picture

lisarex commented
StatusFileSize
new beforeBodyLabelSubmissionGuildelines.png27.55 KB
new afterBodyLabelSubmissionGuildelines.png28.45 KB

Check it out... before and after screenshots :)

I can Skitch them if needed but there's a lot of them to get through!

yched’s picture

yched commented
Component: field_ui.module » node.module

Not related to field_UI.
+ 'Body field label' will disappear in #553306: Make nodes have no body field by default. Remove deprecated APIs for body field

yched’s picture

yched commented
Title: Field UI improvements to body field label and submission guidelines » improvements to body field label and submission guidelines
lisarex’s picture

lisarex commented
StatusFileSize
new cckui_614316_5.patch611 bytes

OK, have removed the body field label and done another patch. Is this the right thing to do?

lisarex’s picture

lisarex commented
Assigned: lisarex » Unassigned
redndahead’s picture

redndahead commented
StatusFileSize
new cckui-614316-6.patch842 bytes

Looks good to me. Added a comma at the end of the line since all array items should end in a comma.

Status: Needs review » Needs work

The last submitted patch failed testing.

heather’s picture

heather commented
Status: Needs work » Reviewed & tested by the community

I tested this with #553306: Make nodes have no body field by default. Remove deprecated APIs for body field applied and without that patch applied.

In both cases #7 works as expected.

Likely it's just because I'm tired... I found it confusing. Am I just thick? Probably just me Video demo of this working:
http://screencast.com/t/ZWRjMWYxZWM

The text makes sense logically... Looks good.

Status: Reviewed & tested by the community » Needs review

webchick requested that failed test be re-tested.

axyjo’s picture

axyjo commented
Status: Needs review » Reviewed & tested by the community

Test passed now. Back to RTBC.

lisarex’s picture

lisarex commented
StatusFileSize
new 614316_11.patch593 bytes

Except Heather makes a good point. The page where this text appears isn't 'Add new content'. It's 'Create [content type]'

I've modified slightly based on the redndahead's patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Hm. I'm not sure that message is clear. In the removed line, it makes it clear where it will show up (at the top of the form). This new message is very vague about it. (it will show up ... SOMETIME..... when creating new content of this type. OOooOOoOOOOo!)

lisarex’s picture

lisarex commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 614316_13.png7.6 KB
new 614316_13.patch594 bytes

oops, comma back in now (this isn't done automatically unfortunately). And screenshot attached.

lisarex’s picture

lisarex commented
Status: Reviewed & tested by the community » Needs work

I can add in 'at the top of the page'?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

"This text will be displayed at the top of the page when creating new content of this type."?

Yep, I think that works! Go Lisa, Go! :D

lisarex’s picture

lisarex commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 614316_17.patch617 bytes
new after614316_17.png8.74 KB

:D Here we go :)

P.S. LOL at "OOooOOoOOOOo!"

lisarex’s picture

lisarex commented
Status: Reviewed & tested by the community » Needs review
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Looks great! Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -ui-text, -D7UX

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +ui-text, +D7UX

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.