improvements to body field label and submission guidelines [#614316]

Comment	File	Size	Author
#17	after614316_17.png	8.74 KB	lisarex
#17	614316_17.patch	617 bytes	lisarex

#14	614316_13.patch	594 bytes	lisarex

#14	614316_13.png	7.6 KB	lisarex
#12	614316_11.patch	593 bytes	lisarex

#7	cckui-614316-6.patch	842 bytes	redndahead

#5	cckui_614316_5.patch	611 bytes	lisarex

#2	afterBodyLabelSubmissionGuildelines.png	28.45 KB	lisarex
#2	beforeBodyLabelSubmissionGuildelines.png	27.55 KB	lisarex
#1	cckui_614316.patch	1014 bytes	lisarex

#1	body_field_label.png	5.82 KB	lisarex
#1	submission_guidelines.png	11.5 KB	lisarex

File	Size
submission_guidelines.png	11.5 KB
body_field_label.png	5.82 KB
cckui_614316.patch	1014 bytes

Comment #2

lisarex CreditAttribution: lisarex commented 25 October 2009 at 23:09

File	Size
beforeBodyLabelSubmissionGuildelines.png	27.55 KB
afterBodyLabelSubmissionGuildelines.png	28.45 KB

Check it out... before and after screenshots :)

I can Skitch them if needed but there's a lot of them to get through!

Log in or register to post comments

Comment #3

yched CreditAttribution: yched commented 25 October 2009 at 23:53

Component:

field_ui.module

» node.module

Not related to field_UI.
+ 'Body field label' will disappear in #553306: Make nodes have no body field by default. Remove deprecated APIs for body field

Log in or register to post comments

Comment #4

yched CreditAttribution: yched commented 25 October 2009 at 23:54

Title:

Field UI improvements to body field label and submission guidelines

» improvements to body field label and submission guidelines

Log in or register to post comments

Comment #5

lisarex CreditAttribution: lisarex commented 26 October 2009 at 01:13

File	Size
cckui_614316_5.patch	611 bytes

OK, have removed the body field label and done another patch. Is this the right thing to do?

Log in or register to post comments

Comment #6

lisarex CreditAttribution: lisarex commented 26 October 2009 at 02:02

Assigned:

lisarex

» Unassigned

Log in or register to post comments

Comment #7

redndahead CreditAttribution: redndahead commented 21 November 2009 at 15:24

File	Size
cckui-614316-6.patch	842 bytes

Looks good to me. Added a comma at the end of the line since all array items should end in a comma.

Log in or register to post comments

Comment #8

21 November 2009 at 16:41

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Comment #9

heather CreditAttribution: heather commented 21 November 2009 at 16:41

Status:

Needs work

» Reviewed & tested by the community

I tested this with #553306: Make nodes have no body field by default. Remove deprecated APIs for body field applied and without that patch applied.

In both cases #7 works as expected.

Likely it's just because I'm tired... I found it confusing. Am I just thick? Probably just me Video demo of this working:
http://screencast.com/t/ZWRjMWYxZWM

The text makes sense logically... Looks good.

Log in or register to post comments

Comment #10

21 November 2009 at 17:26

Status:

Reviewed & tested by the community

» Needs review

webchick requested that failed test be re-tested.

Log in or register to post comments

Comment #11

axyjo CreditAttribution: axyjo commented 21 November 2009 at 17:58

Status:

Needs review

» Reviewed & tested by the community

Test passed now. Back to RTBC.

Log in or register to post comments

Comment #12

lisarex CreditAttribution: lisarex commented 21 November 2009 at 18:00

File	Size
614316_11.patch	593 bytes

Except Heather makes a good point. The page where this text appears isn't 'Add new content'. It's 'Create [content type]'

I've modified slightly based on the redndahead's patch.

Log in or register to post comments

Comment #13

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 21 November 2009 at 18:03

Status:

Reviewed & tested by the community

» Needs review

Hm. I'm not sure that message is clear. In the removed line, it makes it clear where it will show up (at the top of the form). This new message is very vague about it. (it will show up ... SOMETIME..... when creating new content of this type. OOooOOoOOOOo!)