small issue with and styling in search settings page [#59021]

There is a small styling issue in search.module with the warning texts for certain search settings -- these occur around line 224ish in the search .module code as follows;

  $form['indexing_settings']['info'] = array('#type' => 'markup', '#value' => '<em>'. t('<p>Changing the settings below will cause the site index to be rebuilt. The search index is not cleared but systematically updated to reflect the new settings. Searching will continue to work but new content won\'t be indexed until all existing content has been re-indexed.</p><p>The default settings should be appropriate for the majority of sites.</p>') .'</em>');

The hard coded around the definitions cause the width of the content to be slightly too wide in IE6 (okay in mozilla etc.) such that any sidebar/menus drop below the content.

This could be easily avoided if a .definition (or similar) kind of class was used/created instead of hard coding the and styles around the content.

...and on a slightly related issue, there is also inconsistencies with the text used to explain the settings in the "Content ranking" section of this page, as no deifinition is used -- again this could be sorted if a single (exisiting or new) class was used through out.

Comments

Comment #1

pfaocle

He/Him

English

commented 4 May 2006 at 17:10

Version:

4.7.0-rc2

» 4.7.0

Isn't having an em tag outside of p invalid HTML, too?

(Still applies to 4.7 and HEAD)

Comment #2

magico commented 15 September 2006 at 20:02

Version:

4.7.0

» x.y.z

As stated it produces invalid XHTML

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
<head>
  <title>Drupal 5.0</title>
</head>
<body>
<p>some <em>emphasis</em> text</p>
<em>this <p>is invalid</p></em>
<em><p>this is also invalid</p></em>

</body>
</html>