As per the title. I think the attached patch fixes the problem.

CommentFileSizeAuthor
#3 help.patch.txt1.05 KBgopherspidey
help.module.empty_ul.patch831 bytesmarkus_petrux

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

under which conditions do you get empty uls?

markus_petrux’s picture

markus_petrux commented

This is not so obvious here because the number of modules that you may have installed is pretty stable. But it happens.

Try adding/removing modules and visiting admin/help with Firefox's Tidy extension enabled.

I think the rule is when the number of items is divisible by 4. The code I proposed in the patch just makes sure a new UL element is added only when there are more items to show. I think it is efficient so it computes $i+1 just once (it was done twice before) and it just needs to capture the count into a valirable. There might be better ways though.

gopherspidey’s picture

gopherspidey commented
StatusFileSize
new help.patch.txt1.05 KB

I do not see the affect of this patch, but I have rerolled it for the HEAD.

beginner’s picture

beginner commented
Status: Needs review » Fixed

I cannot reproduce the bug.

you have a minimum of 7 help items (required core modules + help), so you cannot have an empty UL.
Even when the number of items is NOT divisible by 4, I do not see any problem as the page validates here http://validator.w3.org/ .

Probably, the bug has been fixed since.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)