Regional > Region - in description at admin page

Either way, I would say this is a task, not a bug.

I was cleaning up outdated issues and came upon this issue today. It's still VALID!

So I rolled a new patch against 8.6.x with the Admin title change to use nouns.

Manually testing.

1. Confirmed /admin/config has a section heading "REGIONAL AND LANGUAGE".
2. Applying patch: $ curl -l https://www.drupal.org/files/issues/2018-04-13/core-text-change-on-admin-page-title-573132-9.patch | git apply -v
3. Applied cleanly.
4. drush cr
5. Reload /admin/config.
6. Section heading now shows "REGION AND LANGUAGE". Screenshot attached and shown below.
7. Also confirmed proper text in breadcrumb trail at /admin/config/regional/settings: Home > Administration > Configuration > Region and language

Moving to RTBC.. I don't think this needs a programmatic test, but I'm also not very familiar with the criteria for that.

Hm, we are not exactly offering the opportunity to set a region anywhere. We are offering settings to configure according to your (geo)cultural environment. Is "region and language" appropriate for that? I see "regional settings" was not even changed in the first item for some reason.

"Region and language" is certainly more correct then "Regional and language" and could be applied without breaking anything.

Grouping country (which defines the default timezone for the site), first day of the week, date formats, and all kind of language and translation issues together however seem to make less sense by now.

To avoid issue creep or hold this up another 9 years, I would go for accepting the patch that just corrects the wording and then try to solve the underlying question of whether the grouping makes sense in a larger context.

I successfully applied the patch and noticed the correct wording. I think it's worth accepting this solution for now.

This looks like it could use more discussion to me. 'Regional and language settings' would be fine here, but a bit duplicative.

I agree that "Regional and language settings" sounds just as good as "Region and language settings" because "regional" and "language" are both used as adjectives in this context. However, the text we changed does not have the word "settings" after it. When "regional and language" is by itself, it sounds grammatically incorrect because "regional" is used as an adjective (with nothing to modify) and "language" is used as a noun. It looks better to have the words match parts of speech, therefore we changed "regional" to "region". Do you agree?

Patch is working fine and applied successfully
After patch Regional text changed to Region
Thanks for the patch for ref sharing screenshot ....

Verified and tested patch #9.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Appearance -> Apply Seven theme
# Goto: /admin/config
# See "Regional and Language" section

Expected Results:
# After applying Patch #9, the User should see "Region and language"

Actual Results:
# Currently user is able to see "Regional and Language"

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

@chetanbharambe, there is not need to add another set of screenshots for the same patch. There are screenshots in the comment previous to yours. Therefor, credit has been removed per How is credit granted for Drupal core issues.

#18 asked for more discussion on the user interface changes. Does this need more?

The Issue summary states there are no user interface changes in this issue and there are. Tagging for an issue summary update.

Tagging this as Novice solely for the issue summary update.

Task: Read through the comments, paying particular attention to #18, #19, #25, #27. Update the issue summary to reflect:

- the current state of what this issue changes
- the current motivation for making those changes
- screenshots of those changes
- what the next steps are

Note that this issue is (very) old, so pay attention to the more recent comments.

Verified and tested patch #9.
Patch applied successfully in Drupal 9.5 on Olivero Theme

Before Patch

After Patch

#9 looks good to me.
Applied patch but not uploading screenshot as #27 is saying so.
After verifying the screenshot of #25 and #31 of Olivero theme looks good for me as in the description is mentioned.

Patch #9 tested and applied successfully for drupal 9.5.x version.
Screenshots attached for reference.

@Manoj Raj.R and @gaurav-mathur:

Thanks for attaching screenshots.

It will make the issue easier to review if you add the screenshots to the issue summary, under the "User interface changes" section.

It will also help if the "Proposed resolution" section is more explicit.

Once we do that, we can remove the "Needs issue summary update" tag added in #27.

@benjifisher
As per advised added the screenshots to the issue summary, under the "User interface changes" section.

@Manoj Raj.R:

Thanks for the updates.

I made the "Proposed resolution" section more explicit by moving some text there from the previous section, along with some other tweaks. I am removing the "Needs issue summary update" tag.

I am removing the "Novice" tag. Although the code change is very simple, the review requested in #18 is not suitable for a novice. Instead, I am adding the "Needs usability review" tag. We can review this issue at an upcoming usability meeting.

Usability review

We discussed this issue at #3314117: Drupal Usability Meeting 2022-10-14. That issue has a link to a recording of the meeting.

For the record, the attendees at the usability meeting were @AaronMcHale, @benjifisher, @rkoller, and @simohell.

Short answer: yes, we approve the change.

Searching the codebase for the string "regional and lang" (case insensitive), I find several matches in the help_topics module. These should be updated as part of this issue, so I am setting the status back to NW. I think that is a Novice task, so I am adding the tag for that.

During the discussion, we also looked at the main admin > configuration page (/admin/config). We should review the order of sections on this page and consider changing it. Coming from this issue, one suggestion to consider is moving the "Region and Language" section closer to "System", which contains "Basic site settings". This review should be a separate issue. Maybe we already have one for it.

As looked out to the last submitted patch #9 found that working as expected and tested by the community as well, as this issue gets opened by @benjifisher, i have applied changes as there are some string for "regional and lang" for help_topics module as seen in #40, So, applying the patch for the latest version 10.1.x and attaching the reroll file.

Changing the state, if found some changes need to be done, please revert it back.

After applying #41 there is no change in admin/config page. 'Regional and language' is not changed to 'Region and language'.
Changing status to needs work. Attached screenshot for reference.

#9 looks good to me.
Patch #9 tested and applied successfully for drupal 10.1.x version.

Patch #41 works as intended, try clearing your caches after applying it.

Given #40 all occurences of the section title have been replaced in the help text and section title itself has been updated.

#41 is RTBC.

This has had usability feedback since Gabor and I both asked for extra feedback on the wording. I'm still not 100% here but it's an improvementment on what's there currently, and adding 'settings' makes everything longer.

Needs to be 10.1.x only now due to the string changes.