Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When you use the administration theme, there is one [hr] added in the bottom. Is there any specific reason for this line, other then to close the body? As it might look oke on listing pages, on forms its looking a bit akward.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | footer-cruft.patch | 603 bytes | gábor hojtsy |
| #4 | LoginOld.png | 21.12 KB | gábor hojtsy |
| #4 | LoginNew.png | 20.01 KB | gábor hojtsy |
| last_line.png | 13.78 KB | Bojhan |
Comments
Comment #1
gábor hojtsyThe body also has a minimal height of 180px we might also want to loose.
Comment #2
Bojhan commentedYhea, saw that - not sure how that looks on the overlay though.
Comment #3
gábor hojtsyRecomponentize.
Comment #4
gábor hojtsyLet's get both fixed at once. The bottom border was due to a top border on the footer which also has some whitespace in there even if it does not contain anything (which is normally how it is). So I'd say we should remove the styles for it. The #footer container is only used for the feed icons, and not as a block region. Also, without this patch, the user login 403 screen looks kind of odd, but with this patch, it almost looks normal (it could use quite some love admittedly).
If the overlay needs some kind of min-height (which I'm not at all sure about), the overlay issue can still fix the theme. Overlay styles are walled off under body#overlay anyway.
Access denied out of the box without the patch:
After patch:
Comment #5
Bojhan commentedDiscussed with Mark, RTBC
Comment #6
webchickNice clean-ups!
Committed to HEAD.