text_field_sanitize() error [#509220]

While working at #504564: Make summary length behave with fields I've noticed this small error so I opened this small issue to not kill kittens there.

text_field_sanitize takes $items by reference, but in its last part assigns values to $item instead of $items.

Comment	File	Size	Author
	text-field-sanitize.patch	807 bytes	tic2000

Comments

Comment #1

tic2000 commented 3 July 2009 at 10:47

Issue tags:

+Quick fix

adding tag

Comment #2

catch

he/him

English

commented 3 July 2009 at 11:12

Status:

Needs review

» Reviewed & tested by the community

Looks good. The other patch is introducing new tests for some of this stuff (not sure if exactly this code though), but let's get it in so that can proceed. Looks like text_field_load() which is a direct copy and paste has this right, so either I fixed the code when copying and pasting, or broke it in hook_field_sanitize() when reworking that...

Comment #3

tic2000 commented 3 July 2009 at 14:58

If "the other patch" means the one I mention in the OP then the last patch has no new test. The one that had a test already got committed, now I only went a step further because the first patch treated the effect, but not the cause.